classification
Title: inspect.getfullargspec does not correctly work with builtin module-level functions
Type: Stage: patch review
Components: Versions: Python 3.4
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: yselivanov Nosy List: larry, ncoghlan, python-dev, yselivanov
Priority: release blocker Keywords: patch

Created on 2014-02-21 00:54 by yselivanov, last changed 2014-03-17 06:30 by python-dev. This issue is now closed.

Files
File name Uploaded Description Edit
sig_bound_01.patch yselivanov, 2014-02-21 00:54 review
sig_bound_02.patch yselivanov, 2014-02-21 05:05 review
Messages (6)
msg211776 - (view) Author: Yury Selivanov (yselivanov) * (Python committer) Date: 2014-02-21 00:54
current behaviour:


>>> import inspect
>>> import os
>>> inspect.getfullargspec(os.stat)
<module 'posix' (built-in)>
FullArgSpec(args=['module', 'path'], varargs=None, varkw=None, defaults=None, kwonlyargs=['dir_fd', 'follow_symlinks'], kwonlydefaults={'dir_fd': None, 'follow_symlinks': True}, annotations={})


'module' argument should not be there.

Patch is attached, please review.
msg211802 - (view) Author: Yury Selivanov (yselivanov) * (Python committer) Date: 2014-02-21 05:05
Updated patch. The entire test suite pass.
msg211806 - (view) Author: Larry Hastings (larry) * (Python committer) Date: 2014-02-21 06:28
I bet you want this cherry-picked; please create a separate issue for that.
msg211808 - (view) Author: Roundup Robot (python-dev) (Python triager) Date: 2014-02-21 06:34
New changeset 2000c27ebe80 by Yury Selivanov in branch 'default':
inspect: Fix getfullargspec to support builtin module-level functions. Issue #20711
http://hg.python.org/cpython/rev/2000c27ebe80
msg211809 - (view) Author: Yury Selivanov (yselivanov) * (Python committer) Date: 2014-02-21 06:36
Thanks Larry!

> I bet you want this cherry-picked
Very much so! I'll create a new issue.
msg213797 - (view) Author: Roundup Robot (python-dev) (Python triager) Date: 2014-03-17 06:30
New changeset ed1059f5507b by Yury Selivanov in branch '3.4':
inspect: Fix getfullargspec to support builtin module-level functions. Issue #20711
http://hg.python.org/cpython/rev/ed1059f5507b
History
Date User Action Args
2014-03-17 06:30:43python-devsetmessages: + msg213797
2014-02-21 06:36:08yselivanovsetstatus: open -> closed
resolution: fixed
messages: + msg211809
2014-02-21 06:34:52python-devsetnosy: + python-dev
messages: + msg211808
2014-02-21 06:28:36larrysetmessages: + msg211806
2014-02-21 05:05:11yselivanovsetfiles: + sig_bound_02.patch

messages: + msg211802
2014-02-21 01:07:39yselivanovsetstage: patch review
2014-02-21 00:54:27yselivanovcreate