classification
Title: test_subprocess is not executed in python -m test.test_asyncio
Type: behavior Stage:
Components: Tests Versions: Python 3.4
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: gvanrossum, python-dev, vajrasky, vstinner
Priority: normal Keywords: patch

Created on 2014-02-17 08:28 by vajrasky, last changed 2014-03-17 06:30 by python-dev. This issue is now closed.

Files
File name Uploaded Description Edit
add_subprocess_to_tests.patch vajrasky, 2014-02-17 08:28 review
permanent_fix_for_executing_test_asyncio_in_bundle.patch vajrasky, 2014-02-17 08:30 review
Messages (7)
msg211398 - (view) Author: Vajrasky Kok (vajrasky) * Date: 2014-02-17 08:28
ethan@amiau:~/Documents/code/python/cpython3.4$ cat Lib/test/test_asyncio/tests.txt 
test_asyncio.test_base_events
test_asyncio.test_events
test_asyncio.test_futures
test_asyncio.test_locks
test_asyncio.test_proactor_events
test_asyncio.test_queues
test_asyncio.test_selector_events
test_asyncio.test_streams
test_asyncio.test_tasks
test_asyncio.test_transports
test_asyncio.test_unix_events
test_asyncio.test_windows_events
test_asyncio.test_windows_utils
ethan@amiau:~/Documents/code/python/cpython3.4$ ls Lib/test/test_asyncio/test_subprocess.py 
Lib/test/test_asyncio/test_subprocess.py

I provide two alternatives to fix this problem.

The first is to add subprocess in tests.txt.
msg211399 - (view) Author: Vajrasky Kok (vajrasky) * Date: 2014-02-17 08:30
The second is the permanent fix so we don't need to add new test to tests.txt every time we want to add new test to asyncio test bundle.
msg211402 - (view) Author: STINNER Victor (vstinner) * (Python committer) Date: 2014-02-17 09:44
I prefer to dynamically discover tests, as we do in all other Python tests. I don't like hardcoded list, it leads to such issue.

@Guido: What do you think?
msg211429 - (view) Author: Guido van Rossum (gvanrossum) * (Python committer) Date: 2014-02-17 17:19
Please apply the fix and make sure it gets cherry-picked.

I agree on dynamic test recovery but don't find it a high priority.
msg211454 - (view) Author: Roundup Robot (python-dev) (Python triager) Date: 2014-02-17 23:12
New changeset b3987d758e49 by Victor Stinner in branch 'default':
Issue #20655: Fix test_asyncio, run also subprocess tests. Patch written by
http://hg.python.org/cpython/rev/b3987d758e49
msg211456 - (view) Author: STINNER Victor (vstinner) * (Python committer) Date: 2014-02-17 23:13
Thanks Vajrasky for your fix. You may open a new issue for  permanent_fix_for_executing_test_asyncio_in_bundle.patch.
msg213802 - (view) Author: Roundup Robot (python-dev) (Python triager) Date: 2014-03-17 06:30
New changeset b22b83ea719d by Victor Stinner in branch '3.4':
Issue #20655: Fix test_asyncio, run also subprocess tests. Patch written by
http://hg.python.org/cpython/rev/b22b83ea719d
History
Date User Action Args
2014-03-17 06:30:47python-devsetmessages: + msg213802
2014-02-17 23:13:11vstinnersetstatus: open -> closed
resolution: fixed
messages: + msg211456
2014-02-17 23:12:05python-devsetnosy: + python-dev
messages: + msg211454
2014-02-17 17:19:56gvanrossumsetmessages: + msg211429
2014-02-17 09:44:48vstinnersetmessages: + msg211402
2014-02-17 08:30:06vajraskysetfiles: + permanent_fix_for_executing_test_asyncio_in_bundle.patch

messages: + msg211399
2014-02-17 08:28:15vajraskycreate