classification
Title: Use specific asserts in ipaddress tests
Type: enhancement Stage: resolved
Components: Tests Versions: Python 3.3, Python 3.4, Python 2.7
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: serhiy.storchaka Nosy List: ncoghlan, pmoody, python-dev, serhiy.storchaka
Priority: normal Keywords: easy, patch

Created on 2014-02-07 20:27 by serhiy.storchaka, last changed 2014-02-08 14:41 by serhiy.storchaka. This issue is now closed.

Files
File name Uploaded Description Edit
test_ipaddress_asserts.patch serhiy.storchaka, 2014-02-07 20:27 review
Messages (4)
msg210550 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2014-02-07 20:27
The proposed patch makes the ipaddress module tests use more specific asserts. This will provide more useful failure report.
msg210645 - (view) Author: Nick Coghlan (ncoghlan) * (Python committer) Date: 2014-02-08 13:58
Changes look fine to me - I did just check in some other updates to test_ipaddress, but I believe they're far enough away from these that the patch should still apply.
msg210651 - (view) Author: Roundup Robot (python-dev) (Python triager) Date: 2014-02-08 14:40
New changeset 58be80e7e653 by Serhiy Storchaka in branch '3.3':
Issue #20553. Use specific asserts in ipaddress tests.
http://hg.python.org/cpython/rev/58be80e7e653

New changeset 2bcb574d579f by Serhiy Storchaka in branch 'default':
Issue #20553. Use specific asserts in ipaddress tests.
http://hg.python.org/cpython/rev/2bcb574d579f
msg210653 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2014-02-08 14:41
Thank you Nick for your review.
History
Date User Action Args
2014-02-08 14:41:50serhiy.storchakasetstatus: open -> closed
messages: + msg210653

assignee: serhiy.storchaka
resolution: fixed
stage: patch review -> resolved
2014-02-08 14:40:25python-devsetnosy: + python-dev
messages: + msg210651
2014-02-08 13:58:37ncoghlansetmessages: + msg210645
2014-02-07 20:30:27serhiy.storchakalinkissue16510 dependencies
2014-02-07 20:27:44serhiy.storchakacreate