classification
Title: Use specific asserts in mailbox, smtplib and poplib tests
Type: enhancement Stage: resolved
Components: Tests Versions: Python 3.3, Python 3.4, Python 2.7
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: serhiy.storchaka Nosy List: giampaolo.rodola, petri.lehtinen, python-dev, r.david.murray, serhiy.storchaka
Priority: normal Keywords: easy, patch

Created on 2014-02-07 20:26 by serhiy.storchaka, last changed 2014-02-08 13:37 by serhiy.storchaka. This issue is now closed.

Files
File name Uploaded Description Edit
test_mailbox_asserts.patch serhiy.storchaka, 2014-02-07 20:26 review
Messages (4)
msg210546 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2014-02-07 20:26
The proposed patch makes the mailbox, smtplib and poplib modules tests use more specific asserts. This will provide more useful failure report.
msg210556 - (view) Author: R. David Murray (r.david.murray) * (Python committer) Date: 2014-02-07 20:56
Looks good to me.
msg210628 - (view) Author: Roundup Robot (python-dev) (Python triager) Date: 2014-02-08 13:07
New changeset 1c3fcba31708 by Serhiy Storchaka in branch '2.7':
Issue #20549: Use specific asserts in mailbox, smtplib and poplib tests.
http://hg.python.org/cpython/rev/1c3fcba31708

New changeset bd1d6916b689 by Serhiy Storchaka in branch '3.3':
Issue #20549: Use specific asserts in mailbox, smtplib and poplib tests.
http://hg.python.org/cpython/rev/bd1d6916b689

New changeset 2e5e66f9e228 by Serhiy Storchaka in branch 'default':
Issue #20549: Use specific asserts in mailbox, smtplib and poplib tests.
http://hg.python.org/cpython/rev/2e5e66f9e228
msg210636 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2014-02-08 13:37
Thank you for your review David.
History
Date User Action Args
2014-02-08 13:37:18serhiy.storchakasetstatus: open -> closed
messages: + msg210636

assignee: serhiy.storchaka
resolution: fixed
stage: patch review -> resolved
2014-02-08 13:07:57python-devsetnosy: + python-dev
messages: + msg210628
2014-02-07 20:56:39r.david.murraysetnosy: + r.david.murray
messages: + msg210556
2014-02-07 20:29:32serhiy.storchakalinkissue16510 dependencies
2014-02-07 20:26:45serhiy.storchakacreate