classification
Title: Update StringIO newline tests
Type: Stage: resolved
Components: IO, Tests Versions: Python 3.3, Python 3.4, Python 2.7
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: benjamin.peterson, hynek, pitrou, python-dev, serhiy.storchaka, stutzbach
Priority: normal Keywords: patch

Created on 2014-02-03 06:57 by serhiy.storchaka, last changed 2014-02-05 13:10 by serhiy.storchaka. This issue is now closed.

Files
File name Uploaded Description Edit
stringio_newline_tests.patch serhiy.storchaka, 2014-02-03 10:52 review
Messages (4)
msg210080 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2014-02-03 06:57
Proposed patches adds several new checks and test cases to StringIO newline tests. It also fixes test_newline_lf which didn't use the newline argument.
msg210110 - (view) Author: Antoine Pitrou (pitrou) * (Python committer) Date: 2014-02-03 10:47
You forgot to add the patch :)
msg210111 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2014-02-03 10:52
Indeed. Here is a patch.
msg210303 - (view) Author: Roundup Robot (python-dev) (Python triager) Date: 2014-02-05 11:43
New changeset 07e7bb29a2c5 by Serhiy Storchaka in branch '2.7':
Issue #20498: Fixed io.StringIO tests for newline='\n'. Added new tests.
http://hg.python.org/cpython/rev/07e7bb29a2c5

New changeset e23c928b9e39 by Serhiy Storchaka in branch '3.3':
Issue #20498: Fixed io.StringIO tests for newline='\n'. Added new tests.
http://hg.python.org/cpython/rev/e23c928b9e39

New changeset 7ed8a9f9831d by Serhiy Storchaka in branch 'default':
Issue #20498: Fixed io.StringIO tests for newline='\n'. Added new tests.
http://hg.python.org/cpython/rev/7ed8a9f9831d
History
Date User Action Args
2014-02-05 13:10:15serhiy.storchakasetstatus: open -> closed
resolution: fixed
stage: patch review -> resolved
2014-02-05 11:43:06python-devsetnosy: + python-dev
messages: + msg210303
2014-02-03 10:52:29serhiy.storchakasetfiles: + stringio_newline_tests.patch
keywords: + patch
messages: + msg210111
2014-02-03 10:47:25pitrousetmessages: + msg210110
2014-02-03 06:57:35serhiy.storchakacreate