classification
Title: test_write_pty() of test_asyncio fails on "x86 Tiger 3.x" buildbot
Type: Stage:
Components: Versions:
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: gvanrossum, ned.deily, pitrou, python-dev, vstinner
Priority: normal Keywords: patch

Created on 2014-02-01 03:20 by vstinner, last changed 2014-02-02 23:37 by vstinner. This issue is now closed.

Files
File name Uploaded Description Edit
asyncio_pty_osx.patch vstinner, 2014-02-02 22:19 review
asyncio_pty_osx-2.patch vstinner, 2014-02-02 23:25 review
Messages (7)
msg209870 - (view) Author: STINNER Victor (vstinner) * (Python committer) Date: 2014-02-01 03:20
http://buildbot.python.org/all/builders/x86%20Tiger%203.x/builds/7801/steps/test/logs/stdio

======================================================================
FAIL: test_write_pty (test.test_asyncio.test_events.PollEventLoopTests)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Users/db3l/buildarea/3.x.bolen-tiger/build/Lib/test/test_asyncio/test_events.py", line 1105, in test_write_pty
    self.assertEqual(b'1', data)
AssertionError: b'1' != b''
msg209873 - (view) Author: Guido van Rossum (gvanrossum) * (Python committer) Date: 2014-02-01 04:12
Well, there were other pty problems on OS X versions before Mavericks (10.9) -- let's just disable this test too using the same approach.
msg209880 - (view) Author: Ned Deily (ned.deily) * (Python committer) Date: 2014-02-01 09:38
FYI, besides 10.4 (Tiger), the test also fails on OS X 10.5 but appears to pass on 10.6 and later releases.
msg210036 - (view) Author: STINNER Victor (vstinner) * (Python committer) Date: 2014-02-02 22:19
Here is a patch to skip the tests for SelectSelector on Mac OS X older than 10.6 (Snow Leopard).

@Ned: Could you please try it? I don't have access to such old Mac OS X versions. (I now only have a iMac running 10.9).
msg210052 - (view) Author: STINNER Victor (vstinner) * (Python committer) Date: 2014-02-02 23:25
Oh, Ned told me that tests using the PollSelector are still failing. I forgot that poll() is also supported on OS X.

Please try this new patch.
msg210053 - (view) Author: Ned Deily (ned.deily) * (Python committer) Date: 2014-02-02 23:31
With asyncio_pty_osx-2.patch, test_asyncio now passes on OS X 10.4.11 and 10.5.8.
msg210054 - (view) Author: Roundup Robot (python-dev) Date: 2014-02-02 23:37
New changeset 21a4ebf5a170 by Victor Stinner in branch 'default':
Issue #20472: test_asyncio: skip PTY tests on Mac OS X older than 10.6
http://hg.python.org/cpython/rev/21a4ebf5a170

New changeset 0a71d29b970a by Victor Stinner in branch 'default':
Issue #20472: asyncio: Adjust the note about Mac OS X on PTY, specify that it
http://hg.python.org/cpython/rev/0a71d29b970a
History
Date User Action Args
2014-02-02 23:37:54vstinnersetstatus: open -> closed
resolution: fixed
2014-02-02 23:37:20python-devsetnosy: + python-dev
messages: + msg210054
2014-02-02 23:31:21ned.deilysetmessages: + msg210053
2014-02-02 23:25:16vstinnersetfiles: + asyncio_pty_osx-2.patch

messages: + msg210052
2014-02-02 22:19:34vstinnersetfiles: + asyncio_pty_osx.patch
keywords: + patch
messages: + msg210036
2014-02-01 09:38:53ned.deilysetnosy: + ned.deily
messages: + msg209880
2014-02-01 04:12:57gvanrossumsetmessages: + msg209873
2014-02-01 03:20:19vstinnercreate