This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Title: Argument Clinic: char convertor should use default values of type bytes
Type: behavior Stage: resolved
Components: Argument Clinic, Build, Demos and Tools Versions: Python 3.8
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: larry, serhiy.storchaka, taleinat
Priority: normal Keywords: patch

Created on 2014-01-19 15:51 by taleinat, last changed 2022-04-11 14:57 by admin. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 8039 merged taleinat, 2018-07-01 08:39
Messages (4)
msg208481 - (view) Author: Tal Einat (taleinat) * (Python committer) Date: 2014-01-19 15:51
For example, in `Object/stringlib/transmogrify.h`, the methods `ljust` and `rjust` have an argument named `fillchar` of type char. It's Python default value should be b' ', but the only way I've found to do that is by setting `py_default = b' '`.
msg208483 - (view) Author: Tal Einat (taleinat) * (Python committer) Date: 2014-01-19 16:05
Additionally, the char converter doesn't create valid c defaults. For example, I got " " instead of ' ' for fillchar, which has type char, so I had to manually set c_default = "' '".
msg320831 - (view) Author: Tal Einat (taleinat) * (Python committer) Date: 2018-07-01 08:27
See PR GH-8039, which fixes this in order to AC convert Objects/stringlib/transmogrify.h.
msg327584 - (view) Author: Tal Einat (taleinat) * (Python committer) Date: 2018-10-12 13:06
This was fixed in PR GH-8039.
Date User Action Args
2022-04-11 14:57:57adminsetgithub: 64503
2018-10-12 13:06:22taleinatsetstatus: open -> closed
resolution: fixed
messages: + msg327584

stage: patch review -> resolved
2018-07-02 07:26:07serhiy.storchakasetnosy: + serhiy.storchaka
2018-07-01 08:39:43taleinatsetkeywords: + patch
stage: patch review
pull_requests: + pull_request7649
2018-07-01 08:27:55taleinatsetmessages: + msg320831
versions: + Python 3.8, - Python 3.4
2015-02-25 15:25:04serhiy.storchakasetcomponents: + Argument Clinic
2014-01-19 16:05:52taleinatsetmessages: + msg208483
2014-01-19 15:51:05taleinatcreate