This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: Derby #14: Convert 41 sites to Argument Clinic across 5 files
Type: enhancement Stage: patch review
Components: Argument Clinic, Extension Modules Versions: Python 3.9
process
Status: open Resolution:
Dependencies: Superseder:
Assigned To: Nosy List: ZackerySpytz, larry, serhiy.storchaka
Priority: normal Keywords: patch

Created on 2014-01-08 00:18 by larry, last changed 2022-04-11 14:57 by admin.

Pull Requests
URL Status Linked Edit
PR 14201 merged ZackerySpytz, 2019-06-18 12:27
PR 14207 open ZackerySpytz, 2019-06-18 18:59
Messages (7)
msg207640 - (view) Author: Larry Hastings (larry) * (Python committer) Date: 2014-01-08 00:18
This issue is part of the Great Argument Clinic Conversion Derby,
where we're trying to convert as much of Python 3.4 to use
Argument Clinic as we can before Release Candidate 1 on January 19.

This issue asks you to change the following bundle of files:
    Modules/mmapmodule.c: 10 sites
    Modules/_localemodule.c: 10 sites
    Modules/zipimport.c: 9 sites
    Modules/ossaudiodev.c: 9 sites
    Modules/_testbuffer.c: 9 sites
    Modules/_struct.c: 3 sites

Talk to me (larry) if you only want to attack part of a bundle.

For instructions on how to convert a function to work with Argument
Clinic, read the "howto":
    http://docs.python.org/dev/howto/clinic.html
msg207651 - (view) Author: Stefan Krah (skrah) * (Python committer) Date: 2014-01-08 00:52
Could you take out _testbuffer.c? It has 100% coverage patches which
would break and it is not a public module.
msg207653 - (view) Author: Larry Hastings (larry) * (Python committer) Date: 2014-01-08 01:03
Sure. Whoever takes ownership of this issue: please ignore _testbuffer.c.
msg224764 - (view) Author: Larry Hastings (larry) * (Python committer) Date: 2014-08-04 20:14
All the Derby patches should only go into trunk at this point.
msg345984 - (view) Author: Zackery Spytz (ZackerySpytz) * (Python triager) Date: 2019-06-18 12:29
PR 14201 converts Modules/_localemodule.c.
msg346003 - (view) Author: Zackery Spytz (ZackerySpytz) * (Python triager) Date: 2019-06-18 19:12
PR 14207 converts Modules/mmapmodule.c.
msg373673 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2020-07-15 09:07
New changeset bbceef6851895135c80e588a55854c1afab46499 by Zackery Spytz in branch 'master':
bpo-20183: Convert _locale to the Argument Clinic (GH-14201)
https://github.com/python/cpython/commit/bbceef6851895135c80e588a55854c1afab46499
History
Date User Action Args
2022-04-11 14:57:56adminsetgithub: 64382
2020-07-15 09:07:54serhiy.storchakasetnosy: + serhiy.storchaka
messages: + msg373673
2019-06-18 19:12:08ZackerySpytzsetmessages: + msg346003
2019-06-18 18:59:35ZackerySpytzsetpull_requests: + pull_request14045
2019-06-18 12:29:46ZackerySpytzsetnosy: + ZackerySpytz

messages: + msg345984
versions: + Python 3.9, - Python 3.5
2019-06-18 12:27:10ZackerySpytzsetkeywords: + patch
stage: needs patch -> patch review
pull_requests: + pull_request14039
2015-02-25 15:29:23serhiy.storchakasetcomponents: + Argument Clinic
2014-10-14 15:42:40skrahsetnosy: - skrah
2014-08-04 20:14:40larrysetmessages: + msg224764
versions: + Python 3.5, - Python 3.4
2014-01-08 01:36:37r.david.murraylinkissue20187 dependencies
2014-01-08 01:03:40larrysetmessages: + msg207653
title: Derby #14: Convert 50 sites to Argument Clinic across 6 files -> Derby #14: Convert 41 sites to Argument Clinic across 5 files
2014-01-08 00:52:55skrahsetnosy: + skrah
messages: + msg207651
2014-01-08 00:18:09larrycreate