classification
Title: Eliminate the use of the deprecated bundlebuilder.py script in OS X builds
Type: enhancement Stage: resolved
Components: Versions: Python 3.5
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: ned.deily Nosy List: eric.snow, ned.deily, python-dev, ronaldoussoren
Priority: low Keywords: needs review, patch

Created on 2013-12-19 04:13 by eric.snow, last changed 2014-03-30 06:59 by ned.deily. This issue is now closed.

Files
File name Uploaded Description Edit
python-launcher-no-bundlebuilder.txt ronaldoussoren, 2013-12-19 12:20 review
Messages (5)
msg206578 - (view) Author: Eric Snow (eric.snow) * (Python committer) Date: 2013-12-19 04:13
Mac/Tools/bundlebuilder.py uses deprecated imp APIs.  It should be refactored to use the current import-related APIs.
msg206591 - (view) Author: Ned Deily (ned.deily) * (Python committer) Date: 2013-12-19 09:32
bundlebuild.py is a deprecated legacy tool that has been superseded by the third-party py2app.  AFAIK, its only use in Python 3 is to build PythonLauncher.app; it is not included in a Python installation.  Rather than refactor it, its use should be eliminated in Mac/PythonLauncher/Makefile.in.
msg206609 - (view) Author: Ronald Oussoren (ronaldoussoren) * (Python committer) Date: 2013-12-19 12:20
Removing bundle builder should be easy enough if it is only used to create the PythonLauncher application bundle: that bundle does not contain python code at all and constructing it is just a matter of copying files to the right location.

The attached patch should do the trick. The patch is very rough, but does work.
msg215172 - (view) Author: Roundup Robot (python-dev) Date: 2014-03-30 06:55
New changeset 3cf72994d5ae by Ned Deily in branch 'default':
Issue #20022: Eliminate use of deprecated bundlebuilder in OS X builds.
http://hg.python.org/cpython/rev/3cf72994d5ae
msg215173 - (view) Author: Ned Deily (ned.deily) * (Python committer) Date: 2014-03-30 06:59
Thanks for the patch, Ronald.  I modified it a bit and also removed bundlebuilder.py from the source tree.  Applied for release in 3.5.0.
History
Date User Action Args
2014-03-30 06:59:52ned.deilysetstatus: open -> closed
title: "modernize" the Mac bundlebuilder.py script -> Eliminate the use of the deprecated bundlebuilder.py script in OS X builds
messages: + msg215173

resolution: fixed
stage: patch review -> resolved
2014-03-30 06:55:10python-devsetnosy: + python-dev
messages: + msg215172
2013-12-19 12:21:06ronaldoussorensetkeywords: + patch, needs review
stage: patch review
2013-12-19 12:20:51ronaldoussorensetfiles: + python-launcher-no-bundlebuilder.txt

messages: + msg206609
2013-12-19 09:32:40ned.deilysetassignee: ned.deily

messages: + msg206591
nosy: + ronaldoussoren, ned.deily
2013-12-19 04:13:34eric.snowcreate