➜
This issue tracker has been migrated to GitHub,
and is currently read-only.
For more information,
see the GitHub FAQs in the Python's Developer Guide.
Created on 2013-12-15 16:05 by christian.heimes, last changed 2022-04-11 14:57 by admin. This issue is now closed.
| Messages (9) | |||
|---|---|---|---|
| msg206237 - (view) | Author: Christian Heimes (christian.heimes) *  |
Date: 2013-12-15 16:05 | |
====================================================================== FAIL: test_alias_fallback (test.test_winsound.PlaySoundTest) ---------------------------------------------------------------------- Traceback (most recent call last): File "E:\home\cpython\buildslave\x86\3.x.snakebite-win2k8r2sp1-x86\build\lib\test\test_winsound.py", line 167, in test_alias_fallback '!"$%&/(#+*', winsound.SND_ALIAS AssertionError: RuntimeError not raised by PlaySound http://buildbot.python.org/all/builders/x86%20Windows%20Server%202008%20%5BSB%5D%203.x/builds/1948/steps/test/logs/stdio |
|||
| msg206242 - (view) | Author: Serhiy Storchaka (serhiy.storchaka) * |
Date: 2013-12-15 17:09 | |
This test was re-enabled in issue19595. |
|||
| msg206312 - (view) | Author: Roundup Robot (python-dev)  |
Date: 2013-12-16 13:54 | |
New changeset 1824fa874f08 by Christian Heimes in branch 'default': Issue #19987: disable test_winsound's test_alias_fallback test when no sound card http://hg.python.org/cpython/rev/1824fa874f08 |
|||
| msg206314 - (view) | Author: Zachary Ware (zach.ware) * |
Date: 2013-12-16 14:09 | |
This is a little odd, since it seems that that buildbot doesn't have a sound card (according to _have_soundcard), but succeeded in playing a sound...although without an ear in the room, we have no way to tell if a sound was played or not. I'm thinking it may be most sane to rewrite the test to call PlaySound in a `try: ... except RuntimeError:` block, and add a comment saying that either outcome is acceptable; a failure would be any other error. |
|||
| msg206316 - (view) | Author: Christian Heimes (christian.heimes) * |
Date: 2013-12-16 14:22 | |
Zach, that sounds like a really good plan. |
|||
| msg206317 - (view) | Author: Zachary Ware (zach.ware) * |
Date: 2013-12-16 14:29 | |
I'll get it committed shortly, thanks Christian. |
|||
| msg206319 - (view) | Author: Roundup Robot (python-dev) |
Date: 2013-12-16 15:05 | |
New changeset f590e9aeb990 by Zachary Ware in branch '2.7': Issue #19987: Re-write test_alias_fallback in test_winsound to have two http://hg.python.org/cpython/rev/f590e9aeb990 New changeset 5455456945d4 by Zachary Ware in branch '3.3': Issue #19987: Re-write test_alias_fallback in test_winsound to have two http://hg.python.org/cpython/rev/5455456945d4 New changeset 1aa6751b298f by Zachary Ware in branch 'default': Issue #19987: Merge with 3.3 http://hg.python.org/cpython/rev/1aa6751b298f |
|||
| msg206335 - (view) | Author: Zachary Ware (zach.ware) * |
Date: 2013-12-16 17:43 | |
The revised test passes on that buildbot on 3.3 and 3.x; the 2.7 build is having permissions issues (and seems to have been for some time). Closing the issue. Thanks for pointing it out and approving the rewrite, Christian! |
|||
| msg206337 - (view) | Author: Christian Heimes (christian.heimes) * |
Date: 2013-12-16 18:03 | |
Awesome! Thanks a lot! :) |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:57:55 | admin | set | github: 64186 |
| 2013-12-16 18:03:41 | christian.heimes | set | messages: + msg206337 |
| 2013-12-16 17:43:23 | zach.ware | set | status: open -> closed resolution: fixed messages: + msg206335 stage: test needed -> resolved |
| 2013-12-16 15:05:53 | python-dev | set | messages: + msg206319 |
| 2013-12-16 14:30:07 | zach.ware | set | assignee: zach.ware |
| 2013-12-16 14:29:57 | zach.ware | set | messages: + msg206317 |
| 2013-12-16 14:22:38 | christian.heimes | set | messages: + msg206316 |
| 2013-12-16 14:09:27 | zach.ware | set | messages: + msg206314 |
| 2013-12-16 13:54:33 | python-dev | set | nosy:
+ python-dev messages: + msg206312 |
| 2013-12-15 17:09:38 | serhiy.storchaka | set | nosy:
- serhiy.storchaka |
| 2013-12-15 17:09:16 | serhiy.storchaka | set | nosy:
+ zach.ware messages: + msg206242 versions: + Python 2.7, Python 3.3 |
| 2013-12-15 16:05:31 | christian.heimes | create | |