This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Title: Write more detailed framing tests
Type: behavior Stage: resolved
Components: Library (Lib), Tests Versions: Python 3.4
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: alexandre.vassalotti, pitrou, python-dev, serhiy.storchaka
Priority: low Keywords: patch

Created on 2013-11-26 15:10 by pitrou, last changed 2022-04-11 14:57 by admin. This issue is now closed.

File name Uploaded Description Edit
frame_tests.patch pitrou, 2013-12-02 22:57 review
Messages (4)
msg204485 - (view) Author: Antoine Pitrou (pitrou) * (Python committer) Date: 2013-11-26 15:10
The pickle tests for protocol 4 currently don't test that framing conforms strictly to the frame structure shown in:

It would be nice to add tests for this, especially the frame size.
msg205063 - (view) Author: Antoine Pitrou (pitrou) * (Python committer) Date: 2013-12-02 22:57
Here is a patch.
msg205087 - (view) Author: Roundup Robot (python-dev) (Python triager) Date: 2013-12-03 08:59
New changeset 1c04427fff07 by Antoine Pitrou in branch 'default':
Issue #19800: make the pickle framing tests more precise.
msg205088 - (view) Author: Antoine Pitrou (pitrou) * (Python committer) Date: 2013-12-03 09:00
Committed with "offset" replaced with "pos".
Date User Action Args
2022-04-11 14:57:54adminsetgithub: 63999
2013-12-03 09:00:06pitrousetstatus: open -> closed
resolution: fixed
messages: + msg205088

stage: resolved
2013-12-03 08:59:34python-devsetnosy: + python-dev
messages: + msg205087
2013-12-02 22:57:36pitrousetfiles: + frame_tests.patch
keywords: + patch
messages: + msg205063
2013-11-26 15:10:25pitroucreate