This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Title: test_logging fails with SMTPHandler timeout
Type: behavior Stage: resolved
Components: Tests Versions: Python 3.4
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: canisdirus, python-dev, vinay.sajip
Priority: normal Keywords: patch

Created on 2013-11-20 18:02 by canisdirus, last changed 2022-04-11 14:57 by admin. This issue is now closed.

File name Uploaded Description Edit
test_logging.patch canisdirus, 2013-11-20 18:02 Patch to up timeout on test_logging.SMTPHandlerTest by 1 sec review
Messages (3)
msg203515 - (view) Author: Mark Wolf (canisdirus) Date: 2013-11-20 18:02
Similar to but with Arch Linux instead of OS X. I built python according the dev guide then ran the test suite with `./python -m test -vj3 test_logging` and failed in the SMTPHandlerTest. `self.handled.is_set()` returns false after a 5 second timeout. In one of the comments in the OS X bug linked above, it suggests changing the timeout to 15 seconds. This causes the test to pass (actually anything slightly over 5 sec seems to be okay). Not sure if this is a fragile test or a bug in Lib.logging. The patch ups the timeout by a second, which passes on my machine but might still fail on others if it actually is a fragile test issue. The failing test runner output for test_logging can be found here:

I'm just jumping into python dev for the first time; any constructive comments are appreciated.
msg205100 - (view) Author: Vinay Sajip (vinay.sajip) * (Python committer) Date: 2013-12-03 11:19
I think the test is fragile, but I'll bump the timeout as suggested.
msg205102 - (view) Author: Roundup Robot (python-dev) (Python triager) Date: 2013-12-03 11:30
New changeset 4c5fc9f08b4d by Vinay Sajip in branch '3.3':
Issue #19665: Increased timeout for SMTPHandler test.

New changeset bfd45dc46569 by Vinay Sajip in branch 'default':
Closes #19665: Merged fi from 3.3.
Date User Action Args
2022-04-11 14:57:53adminsetgithub: 63864
2013-12-03 11:30:06python-devsetstatus: open -> closed

nosy: + python-dev
messages: + msg205102

resolution: fixed
stage: resolved
2013-12-03 11:19:28vinay.sajipsetnosy: + vinay.sajip
messages: + msg205100
2013-11-20 18:02:46canisdiruscreate