This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: Fix PCbuild/readme.txt in 2.7 and 3.3
Type: enhancement Stage: resolved
Components: Documentation, Windows Versions: Python 3.3, Python 2.7
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: zach.ware Nosy List: brian.curtin, christian.heimes, docs@python, ezio.melotti, loewis, python-dev, r.david.murray, tim.golden, vajrasky, zach.ware
Priority: normal Keywords: patch

Created on 2013-10-25 16:34 by zach.ware, last changed 2022-04-11 14:57 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
pcbuild_readme-3.3.diff-w zach.ware, 2013-10-25 16:34 3.3 diff -w
pcbuild_readme-2.7.diff-w zach.ware, 2013-10-25 16:36 2.7 diff -w
pcbuild_readme-2.7.diff zach.ware, 2013-11-03 05:11 2.7 diff review
pcbuild_readme-3.3.diff zach.ware, 2013-11-03 05:13 3.3 diff review
Messages (9)
msg201253 - (view) Author: Zachary Ware (zach.ware) * (Python committer) Date: 2013-10-25 16:34
As discussed in issue19273, here are a pair of patches that correct factual errors in PCbuild/readme.txt in both 2.7 and 3.3.

The 3.3 patch makes the following changes:
- Remove Win2k mentions, it is not supported (Tcl nmake command also adjusted)
- MSVCRT9 -> MSVCRT10
- SQLite 3.7.4 -> 3.7.12, remove "(see below)" with nothing to see
- .vcproj -> .vcxproj, all occurrences 
- _bz2.vcxproj isn't as magical as it was made out to be, and it can clean itself
- nasmw -> nasm
- Remove untrue part of Building for Itanium section
- Update msdn link
- .vsprops -> .props
- Trim trailing space

Due to the large number of lines in the diff due to trailing space, I'll also be attaching a patch created by `hg diff -w` for ease of review.
msg201254 - (view) Author: Zachary Ware (zach.ware) * (Python committer) Date: 2013-10-25 16:36
The 2.7 patch makes the following changes:
- python30.dll -> python27.dll
- remove "(see below)" from _bsddb and _sqlite3 which have nothing to see below
- bz2.vcproj isn't as magical as it made out to be, and it can clean itself
- nasmw -> nasm
- Remove untrue part of Building for Itanium section
- Update msdn link
- Trim trailing space

There is also a diff -w patch for 2.7, due to the large number of lines with trailing space.
msg201992 - (view) Author: Vajrasky Kok (vajrasky) * Date: 2013-11-03 04:48
Zachary, perharps you could make a diff with mercurial so we can have Rietveld review link. I don't know whether git can do that or not.
msg201993 - (view) Author: Zachary Ware (zach.ware) * (Python committer) Date: 2013-11-03 05:07
These diffs are produced by `hg diff --git`.  If I'm not mistaken, the reason there is no review link is because these patches are not against default branch.  Here's one without the `--git` option though, just to see if I'm wrong :).  If I am, I'll replace all of them.
msg201994 - (view) Author: Zachary Ware (zach.ware) * (Python committer) Date: 2013-11-03 05:11
How wrong I was...
msg201995 - (view) Author: R. David Murray (r.david.murray) * (Python committer) Date: 2013-11-03 05:25
With the --git option, the rietveld service only tries against the default branch.  Without the --git option, it can figure out the changeset the patch is based against and use that.
msg202069 - (view) Author: Brian Curtin (brian.curtin) * (Python committer) Date: 2013-11-03 23:56
Both patches look fine to me.
msg202080 - (view) Author: Roundup Robot (python-dev) (Python triager) Date: 2013-11-04 03:53
New changeset 7b6ac858bb17 by Zachary Ware in branch '2.7':
Issue #19391: Clean up PCbuild/readme.txt
http://hg.python.org/cpython/rev/7b6ac858bb17

New changeset f28a2d072767 by Zachary Ware in branch '3.3':
Issue #19391: Clean up PCbuild/readme.txt
http://hg.python.org/cpython/rev/f28a2d072767
msg202081 - (view) Author: Zachary Ware (zach.ware) * (Python committer) Date: 2013-11-04 03:58
Thanks for the lesson, Vajrasky and David, and thank you for the review Brian.

The final commit did have a couple changes not in the posted patch, just fixes of the same two obvious typos in both branches (avalible -> available, lniked -> linked).
History
Date User Action Args
2022-04-11 14:57:52adminsetgithub: 63590
2013-11-04 03:58:45zach.waresetstatus: open -> closed
resolution: fixed
messages: + msg202081

stage: patch review -> resolved
2013-11-04 03:53:10python-devsetmessages: + msg202080
2013-11-03 23:56:39brian.curtinsetmessages: + msg202069
2013-11-03 05:25:42r.david.murraysetnosy: + r.david.murray
messages: + msg201995
2013-11-03 05:15:35zach.waresetfiles: - pcbuild_readme-2.7.diff-w-no-git
2013-11-03 05:13:53zach.waresetfiles: + pcbuild_readme-3.3.diff
2013-11-03 05:13:40zach.waresetfiles: - pcbuild_readme-3.3.diff
2013-11-03 05:11:57zach.waresetfiles: + pcbuild_readme-2.7.diff

messages: + msg201994
2013-11-03 05:11:42zach.waresetfiles: - pcbuild_readme-2.7.diff
2013-11-03 05:07:55zach.waresetfiles: + pcbuild_readme-2.7.diff-w-no-git

messages: + msg201993
2013-11-03 04:48:53vajraskysetnosy: + vajrasky
messages: + msg201992
2013-11-03 03:34:26zach.waresetassignee: docs@python -> zach.ware
stage: patch review
2013-10-25 16:36:42zach.waresetfiles: + pcbuild_readme-2.7.diff-w
2013-10-25 16:36:27zach.waresetfiles: + pcbuild_readme-2.7.diff

messages: + msg201254
2013-10-25 16:34:51zach.waresetfiles: + pcbuild_readme-3.3.diff-w
2013-10-25 16:34:30zach.warecreate