This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Title: nturl2path test coverage
Type: enhancement Stage: patch review
Components: Tests Versions: Python 3.4
Status: open Resolution:
Dependencies: Superseder:
Assigned To: Nosy List: Colin.Williams, ezio.melotti, orsenthil
Priority: normal Keywords: patch

Created on 2013-10-24 23:33 by Colin.Williams, last changed 2022-04-11 14:57 by admin.

File name Uploaded Description Edit
nturl2path.patch Colin.Williams, 2013-10-24 23:33 review
Messages (2)
msg201197 - (view) Author: Colin Williams (Colin.Williams) Date: 2013-10-24 23:33
Full coverage on this module
msg203107 - (view) Author: Ezio Melotti (ezio.melotti) * (Python committer) Date: 2013-11-16 23:45
The assertions have their arguments in the wrong order, it should be (actual, expected).
In the code of the module there are also some examples in the comments, e.g.:
# path is something like ////host/path/on/remote/host
# convert this to \\host\path\on\remote\host
Even though the path is covered, there's no similar test in this patch.
I would suggest you to include all the examples from the module in the tests.

Also note that this module is already indirectly tested in test_urllib.
Date User Action Args
2022-04-11 14:57:52adminsetgithub: 63582
2013-11-16 23:45:11ezio.melottisetnosy: + ezio.melotti
messages: + msg203107

type: enhancement
stage: patch review
2013-10-25 02:03:48berker.peksagsetcomponents: + Tests
versions: + Python 3.4
2013-10-24 23:49:00orsenthilsetnosy: + orsenthil
2013-10-24 23:33:34Colin.Williamscreate