This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: duplicate test names in Lib/ctypes/test/test_functions.py
Type: behavior Stage: resolved
Components: Library (Lib) Versions: Python 3.11
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: FFY00, amaury.forgeotdarc, andrei.avk, belopolsky, ezio.melotti, furkanonder, lukasz.langa, meador.inge, shihai1991, xdegaye
Priority: normal Keywords: patch

Created on 2013-09-28 16:23 by xdegaye, last changed 2022-04-11 14:57 by admin. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 28008 merged andrei.avk, 2021-08-27 21:16
Messages (8)
msg198529 - (view) Author: Xavier de Gaye (xdegaye) * (Python triager) Date: 2013-09-28 16:23
After renaming the first test_errors method to test_errors_1 and the
second one to test_errors_2:

$ /bin/sh -c "cd Lib/ctypes/test; ../../../python runtests.py test_functions.py"
....F................
======================================================================
FAIL: test_errors_1 (ctypes.test.test_functions.FunctionTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "./Lib/ctypes/test/test_functions.py", line 227, in test_errors_1
    self.assertRaises(TypeError, f, X()) #cannot convert parameter
AssertionError: TypeError not raised by _testfunc_p_p

----------------------------------------------------------------------
Ran 21 tests in 0.007s

FAILED (failures=1)
msg227985 - (view) Author: Mark Lawrence (BreamoreBoy) * Date: 2014-09-30 19:30
@Xavier can you provide a patch for this issue?
msg228060 - (view) Author: Xavier de Gaye (xdegaye) * (Python triager) Date: 2014-10-01 07:51
This issue has been entered while checking for duplicate test names in issue 16079.
msg340115 - (view) Author: Xavier de Gaye (xdegaye) * (Python triager) Date: 2019-04-12 21:57
Still fails on Python 3.8.0a3+.
msg348245 - (view) Author: Hai Shi (shihai1991) * (Python triager) Date: 2019-07-21 14:10
en, in python 3.8.0a3, I got those other error info:

$ /home/shihai/workspace/cpython/python test_functions.py

ERROR:root:code for hash md5 was not found.
Traceback (most recent call last):
  File "/home/shihai/workspace/cpython/Lib/hashlib.py", line 244, in <module>
    globals()[__func_name] = __get_hash(__func_name)
  File "/home/shihai/workspace/cpython/Lib/hashlib.py", line 113, in __get_builtin_constructor
    raise ValueError('unsupported hash type ' + name)
ValueError: unsupported hash type md5

but in master branch, the test case is ok.
msg366674 - (view) Author: Furkan Onder (furkanonder) * Date: 2020-04-17 19:04
There are two tests with same name in the same test class  (ctypes.test.test_functions test_errors)
After merging both and re-run I encounter with this error
which looks like it was always there but overwritten by other test (with same name)

....F...........s.s...
======================================================================
FAIL: test_errors (__main__.FunctionTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/furkan/cpython/Lib/ctypes/test/test_functions.py", line 219, in test_errors
    self.assertRaises(TypeError, f, X()) #cannot convert parameter
AssertionError: TypeError not raised by _testfunc_p_p

----------------------------------------------------------------------
Ran 22 tests in 0.003s
msg401391 - (view) Author: Łukasz Langa (lukasz.langa) * (Python committer) Date: 2021-09-08 15:28
New changeset a5610057615779ca6fc75d9e006d2fae644a94d3 by andrei kulakov in branch 'main':
bpo-19113: Remove unused test_errors from ctypes tests (GH-28008)
https://github.com/python/cpython/commit/a5610057615779ca6fc75d9e006d2fae644a94d3
msg401392 - (view) Author: Łukasz Langa (lukasz.langa) * (Python committer) Date: 2021-09-08 15:32
Change made in Python 3.11: duplicate test removed. Closing.
History
Date User Action Args
2022-04-11 14:57:51adminsetgithub: 63312
2021-09-08 15:32:29lukasz.langasetstatus: open -> closed
versions: + Python 3.11, - Python 2.7, Python 3.7, Python 3.8
messages: + msg401392

resolution: fixed
stage: patch review -> resolved
2021-09-08 15:28:41lukasz.langasetnosy: + lukasz.langa
messages: + msg401391
2021-08-27 21:16:25andrei.avksetkeywords: + patch
nosy: + andrei.avk

pull_requests: + pull_request26450
stage: needs patch -> patch review
2020-05-03 00:05:37FFY00setnosy: + FFY00
2020-04-17 19:04:34furkanondersetnosy: + furkanonder
messages: + msg366674
2019-07-21 14:10:07shihai1991setnosy: + shihai1991
messages: + msg348245
2019-04-25 14:54:02xdegayesetversions: + Python 3.7
2019-04-24 15:25:45xdegayesetversions: + Python 2.7, Python 3.8, - Python 3.4, Python 3.5
2019-04-13 07:58:52BreamoreBoysetnosy: - BreamoreBoy
2019-04-12 21:57:16xdegayesetmessages: + msg340115
2016-04-24 20:34:16berker.peksaglinkissue26841 superseder
2014-10-01 07:51:26xdegayesetmessages: + msg228060
2014-09-30 19:30:52BreamoreBoysetnosy: + BreamoreBoy

messages: + msg227985
versions: + Python 3.5
2013-10-05 03:13:32ezio.melottisetnosy: + ezio.melotti

stage: needs patch
2013-09-28 16:23:39xdegayecreate