classification
Title: test_sax fails on Windows under 3.4.0a2
Type: Stage:
Components: Tests Versions: Python 3.4
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: loewis, ned.deily, serhiy.storchaka, tim.peters
Priority: normal Keywords:

Created on 2013-09-10 01:02 by tim.peters, last changed 2013-09-10 20:14 by tim.peters. This issue is now closed.

Files
File name Uploaded Description Edit
test_sax.out tim.peters, 2013-09-10 01:02
Messages (9)
msg197415 - (view) Author: Tim Peters (tim.peters) * (Python committer) Date: 2013-09-10 01:02
Don't know whether this is new.  Found it running the test suite under a 3.4.0a2 freshly installed from the python.org .msi installer:

== CPython 3.4.0a2 (v3.4.0a2:9265a2168e2c+, Sep 8 2013, 19:41:05) [MSC v.1600 32 bit (Intel)]
==   Windows-Vista-6.0.6002-SP2 little-endian

`regrtest -v test_sax` output attached.  Interestingly, test_sax passes under the tip HG Pythons I build myself.

Didn't we recently fix something like this???  Appears to be a line-end problem.  Ya!  Whoever builds the Windows installer needs to delete directory Lib\test\xmltestdata on their box, and then do "hg revert" on that directory to get fresh copies of the test data.  .hgeol was changed to treat those files as binary, but Mercurial doesn't replace the files automatically just because .hgeol changed.
msg197416 - (view) Author: Ned Deily (ned.deily) * (Python committer) Date: 2013-09-10 01:48
Martin builds the Windows installers.
msg197431 - (view) Author: Martin v. Löwis (loewis) * (Python committer) Date: 2013-09-10 09:41
Is there an easy way to recheck the entire tree, possibly reverting any files that don't match the content that they should have? I'd rather not throw the tree away.
msg197432 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2013-09-10 10:10
hg update -C default
msg197454 - (view) Author: Tim Peters (tim.peters) * (Python committer) Date: 2013-09-10 16:28
Serhiy, did you test "hg update -C default"?  Didn't work for me :-(

Martin, I don't know an easy way.  eol fiddling in Hg seems brittle :-(

I suppose you could get a fresh clone and then _compare_ the checked-out files to your old clone.  Then, from the old clone, delete the files that don't match.  Then "hg revert -a" in the old clone.  Then check again.  If they all match, throw away the new clone.  But, no, that's not really easy ;-)
msg197458 - (view) Author: Tim Peters (tim.peters) * (Python committer) Date: 2013-09-10 18:12
OK, "hg up -C" _can_ work, but it appears to require that "hg stat" shows that the files with the "bad" line endings are modified (M).  That may or may not be the case, depending on lots of things.

Martin, can you verify that (for example) test.xml.out does have \r\n line ends in your tree?  Maybe it doesn't, and the problem really lies elsewhere (unsure - some step in building the .msi, or maybe even the .msi changes line ends during installation - don't know).

I think bad line endings in the tree are most likely, though, since test_sax was failing in the same way for (at least) me and Terry Reddy when building our own Pythons on Windows, before changing .hgeol.
msg197459 - (view) Author: Tim Peters (tim.peters) * (Python committer) Date: 2013-09-10 18:15
BTW, the reason I wonder whether you don't have bad line ends in your tree is this:  if you did, test_sax would have been failing for you too.  I assume you run the test suite before building the installer ;-)
msg197462 - (view) Author: Martin v. Löwis (loewis) * (Python committer) Date: 2013-09-10 19:07
It turns out that TortoiseHg was showing the files as modified. I have now "reverted" my local changes, so this should be fine now. I was somewhat under time pressure when making the release, so I didn't notice then (and TortoiseHg seems to needs some time also to detect modifications and reversals).

And no, I don't run the test suite when making a release. If a test was failing, I would have to research what the problem is (or ignore the failure), which could easily delay the release by several days. I only verify that IDLE starts and the help file opens.

Thanks for your investigation.
msg197466 - (view) Author: Tim Peters (tim.peters) * (Python committer) Date: 2013-09-10 20:14
No problems, Martin - thanks for following up on this! :-)
History
Date User Action Args
2013-09-10 20:14:12tim.peterssetmessages: + msg197466
2013-09-10 19:07:48loewissetstatus: open -> closed
resolution: fixed
messages: + msg197462
2013-09-10 18:15:17tim.peterssetmessages: + msg197459
2013-09-10 18:12:35tim.peterssetmessages: + msg197458
2013-09-10 16:28:39tim.peterssetmessages: + msg197454
2013-09-10 10:10:11serhiy.storchakasetnosy: + serhiy.storchaka
messages: + msg197432
2013-09-10 09:41:10loewissetmessages: + msg197431
2013-09-10 01:48:59ned.deilysetnosy: + loewis, ned.deily
messages: + msg197416
2013-09-10 01:02:25tim.peterscreate