classification
Title: test_regrtest.test_timeout failure
Type: behavior Stage: resolved
Components: Tests Versions: Python 3.4
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: neologix, pitrou, python-dev, vstinner
Priority: normal Keywords: needs review, patch

Created on 2013-09-05 16:59 by neologix, last changed 2013-09-08 11:11 by neologix. This issue is now closed.

Files
File name Uploaded Description Edit
test_timeout.diff neologix, 2013-09-05 16:59 review
Messages (5)
msg197013 - (view) Author: Charles-François Natali (neologix) * (Python committer) Date: 2013-09-05 16:59
http://buildbot.python.org/all/builders/AMD64 Fedora without threads 3.x/builds/5074/steps/test/logs/stdio
"""
======================================================================
FAIL: test_timeout (test.test_regrtest.ParseArgsTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.x.krah-fedora/build/Lib/test/test_regrtest.py", line 30, in test_timeout
    self.assertEqual(ns.timeout, 4.2)
AssertionError: None != 4.2
"""

That's because the "--timeout" isn't supported if Python is built --without-threads.

Possible patch attached.
msg197241 - (view) Author: Charles-François Natali (neologix) * (Python committer) Date: 2013-09-08 09:54
Anyone? (The patch is trivial, but I'm not familiar with regrtest).
msg197243 - (view) Author: STINNER Victor (vstinner) * (Python committer) Date: 2013-09-08 09:59
The patch looks good to me.
msg197245 - (view) Author: Roundup Robot (python-dev) (Python triager) Date: 2013-09-08 10:36
New changeset 2982ac8b45bc by Charles-François Natali in branch 'default':
Issue #18935: Fix test_regrtest.test_timeout when built --without-threads (the
http://hg.python.org/cpython/rev/2982ac8b45bc
msg197250 - (view) Author: Charles-François Natali (neologix) * (Python committer) Date: 2013-09-08 11:11
Committed.
History
Date User Action Args
2013-09-08 11:11:25neologixsetstatus: open -> closed
resolution: fixed
messages: + msg197250

stage: patch review -> resolved
2013-09-08 10:36:14python-devsetnosy: + python-dev
messages: + msg197245
2013-09-08 09:59:02vstinnersetmessages: + msg197243
2013-09-08 09:54:55neologixsetmessages: + msg197241
2013-09-05 16:59:58neologixcreate