➜
This issue tracker has been migrated to GitHub,
and is currently read-only.
For more information,
see the GitHub FAQs in the Python's Developer Guide.
Created on 2013-08-28 19:32 by pitrou, last changed 2022-04-11 14:57 by admin. This issue is now closed.
| Files | ||||
|---|---|---|---|---|
| File name | Uploaded | Description | Edit | |
| test_suite.patch | pitrou, 2013-08-28 19:32 | |||
| Messages (7) | |||
|---|---|---|---|
| msg196405 - (view) | Author: Antoine Pitrou (pitrou) *  |
Date: 2013-08-28 19:32 | |
Here is a proposal to make the devguide more precise and explicit about needing to run the entire test suite before committing a change. |
|||
| msg196410 - (view) | Author: R. David Murray (r.david.murray) * |
Date: 2013-08-28 19:51 | |
Looks OK to me. Do we want to also recommend more explicitly that the tests be run with -uall? |
|||
| msg196412 - (view) | Author: Antoine Pitrou (pitrou) * |
Date: 2013-08-28 20:16 | |
I don't know. I wouldn't insist too much on -uall, because generally it won't find anything more (except for network tests, perhaps). |
|||
| msg196426 - (view) | Author: Nick Coghlan (ncoghlan) * |
Date: 2013-08-28 21:36 | |
Looks good to me. I think it's OK to leave the optional resources in the set of things covered by the buildbots rather than expecting them to always be run in pre-commit testing. |
|||
| msg196427 - (view) | Author: Roundup Robot (python-dev)  |
Date: 2013-08-28 21:51 | |
New changeset a62bb0481ac9 by Antoine Pitrou in branch 'default': Issue #18871: make it more explicit that the test suite should be run before committing http://hg.python.org/devguide/rev/a62bb0481ac9 |
|||
| msg196428 - (view) | Author: Antoine Pitrou (pitrou) * |
Date: 2013-08-28 21:52 | |
Thanks for allowing me to be lazy, Nick :-) |
|||
| msg196430 - (view) | Author: Nick Coghlan (ncoghlan) * |
Date: 2013-08-28 22:12 | |
The fact I don't run the tests with - uall before committing had nothing to do with it whatsoever. Nope. Nothing at all ;) |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:57:50 | admin | set | github: 63071 |
| 2013-08-28 22:12:23 | ncoghlan | set | messages: + msg196430 |
| 2013-08-28 21:52:40 | pitrou | set | status: open -> closed resolution: fixed messages: + msg196428 stage: resolved |
| 2013-08-28 21:51:47 | python-dev | set | nosy:
+ python-dev messages: + msg196427 |
| 2013-08-28 21:36:30 | ncoghlan | set | messages: + msg196426 |
| 2013-08-28 20:16:18 | pitrou | set | messages: + msg196412 |
| 2013-08-28 19:51:10 | r.david.murray | set | messages: + msg196410 |
| 2013-08-28 19:32:58 | pitrou | create | |