classification
Title: Typo and unused variables in test fcntl
Type: enhancement Stage: resolved
Components: Tests Versions: Python 3.3, Python 3.4, Python 2.7
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: ezio.melotti Nosy List: ezio.melotti, python-dev, vajrasky
Priority: normal Keywords: patch

Created on 2013-08-21 10:29 by vajrasky, last changed 2013-08-23 20:10 by ezio.melotti. This issue is now closed.

Files
File name Uploaded Description Edit
fix_typo_unused_variables_in_test_fcntl.patch vajrasky, 2013-08-21 10:29 review
Messages (3)
msg195768 - (view) Author: Vajrasky Kok (vajrasky) * Date: 2013-08-21 10:29
Typo in line 11:
# Skip test if no fnctl module.

Unused variables rv in test_fcntl_file_descriptor method.

Attached the patch to clean up the test.
msg196019 - (view) Author: Roundup Robot (python-dev) (Python triager) Date: 2013-08-23 20:09
New changeset d7bac470951b by Ezio Melotti in branch '2.7':
#18798: fix typo in test_fcntl.  Patch by Vajrasky Kok.
http://hg.python.org/cpython/rev/d7bac470951b

New changeset 41c90b8f49d9 by Ezio Melotti in branch '3.3':
#18798: fix typo in test_fcntl.  Patch by Vajrasky Kok.
http://hg.python.org/cpython/rev/41c90b8f49d9

New changeset 0f8f5fd6e712 by Ezio Melotti in branch 'default':
#18798: merge typo fix from 3.3 and also use two unused variables.
http://hg.python.org/cpython/rev/0f8f5fd6e712
msg196020 - (view) Author: Ezio Melotti (ezio.melotti) * (Python committer) Date: 2013-08-23 20:10
Fixed, thanks for the report and the patch!
History
Date User Action Args
2013-08-23 20:10:23ezio.melottisetstatus: open -> closed

type: enhancement
assignee: ezio.melotti
versions: + Python 2.7, Python 3.3
nosy: + ezio.melotti

messages: + msg196020
resolution: fixed
stage: resolved
2013-08-23 20:09:53python-devsetnosy: + python-dev
messages: + msg196019
2013-08-21 10:29:20vajraskycreate