This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: IdleHistory.History: eliminate unused parameter; other cleanup.
Type: performance Stage: resolved
Components: IDLE Versions: Python 3.3, Python 3.4, Python 2.7
process
Status: closed Resolution: fixed
Dependencies: 18425 Superseder:
Assigned To: terry.reedy Nosy List: python-dev, terry.reedy
Priority: normal Keywords:

Created on 2013-08-13 21:20 by terry.reedy, last changed 2022-04-11 14:57 by admin. This issue is now closed.

Messages (2)
msg195099 - (view) Author: Terry J. Reedy (terry.reedy) * (Python committer) Date: 2013-08-13 21:20
idlelib.IdleHistory is only imported in PyShell.PyShell. History is only instantiated once, with output_sep defaulting to \n. This constant parameter and the consequence splitting and joining with \n in ._get_source and ._put_source are useless. After the tests for this class are committed in #18425, I plan to eliminate the unneeded parameter, splits, joins, and methods and inline the remaining text.get and .insert in .fetch. I want to do a few other transparent modernizations in the .fetch code, such as replacing 4 of the lines with
 pointer += -1 if reverse else 1
msg195283 - (view) Author: Roundup Robot (python-dev) (Python triager) Date: 2013-08-15 20:19
New changeset 7339dcff171f by Terry Jan Reedy in branch '2.7':
Issue #18732: Remove unused* parameter output_sep from IdleHistory.History
http://hg.python.org/cpython/rev/7339dcff171f

New changeset 3105b78d3434 by Terry Jan Reedy in branch '3.3':
Issue #18732: Remove unused* parameter output_sep from IdleHistory.History
http://hg.python.org/cpython/rev/3105b78d3434
History
Date User Action Args
2022-04-11 14:57:49adminsetgithub: 62932
2013-08-15 20:21:32terry.reedysetstatus: open -> closed
resolution: fixed
stage: needs patch -> resolved
2013-08-15 20:19:55python-devsetnosy: + python-dev
messages: + msg195283
2013-08-15 19:11:33terry.reedylinkissue18425 superseder
2013-08-13 21:20:50terry.reedysetdependencies: + IDLE Unit test for IdleHistory.py
2013-08-13 21:20:31terry.reedycreate