This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Title: Minor fixes for test_coding
Type: enhancement Stage: resolved
Components: Tests Versions: Python 3.3, Python 3.4
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: serhiy.storchaka Nosy List: lemburg, loewis, nnorwitz, python-dev, serhiy.storchaka, vstinner
Priority: normal Keywords: patch

Created on 2013-06-13 08:03 by serhiy.storchaka, last changed 2022-04-11 14:57 by admin. This issue is now closed.

File name Uploaded Description Edit
test_coding.patch serhiy.storchaka, 2013-06-13 08:04 Patch for 3.3 review
Messages (4)
msg191066 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2013-06-13 08:03
Here is a patch which contains followed changes:

* Use bytes in test_exec_valid_coding(). Encoding instruction is ignored in strings.
* Use non-ascii data in test_exec_valid_coding() to check that encoding is working.
* Use explicit file encoding in test_file_parse().
* Use with statement for file in test_file_parse().
* Modify sys.path after opening file in test_file_parse() and restore before other cleanups.
* Cleanup '.pyo' file in test_file_parse(). Test can ran in optimized mode.
* Add msg parameter for better failure reporting in test_error_from_string().
* Use unittest.main().
msg191438 - (view) Author: STINNER Victor (vstinner) * (Python committer) Date: 2013-06-18 22:24
The patch looks good to me. It may be better to split it in two commits: fix test_exec_valid_coding() in Python 3.3, cleanup test only in python 3.4. As you want.
msg191452 - (view) Author: Roundup Robot (python-dev) (Python triager) Date: 2013-06-19 07:31
New changeset 410ea970866e by Serhiy Storchaka in branch '3.3':
Issue #18202: Fix minor bugs and cleanup

New changeset 959f4ce4d590 by Serhiy Storchaka in branch 'default':
Issue #18202: Fix minor bugs and cleanup
msg191453 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2013-06-19 07:35
Not all other changes are cleanups and enhancements. Some of them also fix minor bugs.

Thank you for review Victor.
Date User Action Args
2022-04-11 14:57:46adminsetgithub: 62402
2013-06-19 07:35:24serhiy.storchakasetstatus: open -> closed
messages: + msg191453

assignee: serhiy.storchaka
resolution: fixed
stage: patch review -> resolved
2013-06-19 07:31:49python-devsetnosy: + python-dev
messages: + msg191452
2013-06-18 22:24:44vstinnersetmessages: + msg191438
2013-06-13 22:58:26vstinnersetnosy: + vstinner
2013-06-13 08:04:44serhiy.storchakasetfiles: + test_coding.patch
2013-06-13 08:03:49serhiy.storchakasetfiles: - test_coding.patch
2013-06-13 08:03:07serhiy.storchakacreate