Hi,

splitting off issue18061 by request of pitrou:

struct alignment issue: PyException_HEAD misses explicit alignment instruction; uses invalid (non-portable) alignment assumptions. ABI change on m68k.

See issue18061 for details.

> ② This one is pretty severe: AssertionError: 42 != 44 : wrong size for 
> <class 'BaseException'>: got 42, expected 44

What is the context? test_sys?

Yes, that's in test_sys.

I suppose it's in SizeofTest specifically (in the future, please quote more detailed test information; you can get it by replaying a test in verbose mode, e.g. "./python -m test -v test_sys").

Can you post the output of:

>>> struct.calcsize("PPnP5Pb")

>>> struct.calcsize("PPnP5Pi")

>>> struct.calcsize("PPnP5Pb0P")

>>> struct.calcsize("PPnP5Pi0P")

>>> struct.calcsize("PPnP5Pb")
37
>>> struct.calcsize("PPnP5Pi")
40
>>> struct.calcsize("PPnP5Pb0P")
38
>>> struct.calcsize("PPnP5Pi0P")
40

I already offered to re-run tests in verbose mode “on request” if needed, but the results.txt I attached to issue18061 contains them for test_sys (it apparently got re-run verbosely automatically).

Ok, can you try applying the following patch:

diff --git a/Lib/test/test_sys.py b/Lib/test/test_sys.py
--- a/Lib/test/test_sys.py
+++ b/Lib/test/test_sys.py
@@ -703,13 +703,13 @@ class SizeofTest(unittest.TestCase):
         class C(object): pass
         check(C.__dict__, size('P'))
         # BaseException
-        check(BaseException(), size('5Pi'))
+        check(BaseException(), size('5Pb'))
         # UnicodeEncodeError
-        check(UnicodeEncodeError("", "", 0, 0, ""), size('5Pi 2P2nP'))
+        check(UnicodeEncodeError("", "", 0, 0, ""), size('5Pb 2P2nP'))
         # UnicodeDecodeError
-        check(UnicodeDecodeError("", b"", 0, 0, ""), size('5Pi 2P2nP'))
+        check(UnicodeDecodeError("", b"", 0, 0, ""), size('5Pb 2P2nP'))
         # UnicodeTranslateError
-        check(UnicodeTranslateError("", 0, 1, ""), size('5Pi 2P2nP'))
+        check(UnicodeTranslateError("", 0, 1, ""), size('5Pb 2P2nP'))
         # ellipses
         check(Ellipsis, size(''))
         # EncodingMap

Sure (attached).

Include/unicodeobject.h has the same problem; its “state” member currently allocates 8 bit, which is only padded up to 16 bit.

asciifields = "nnbP" makes that work too; result attached as after-patch-2.txt

Will just changing the testsuite to match reality be enough, or are there any other internal assumptions about this type of thing, like we had with issue17237 earlier?

Thanks for your quick responses!

Thank you. This is just a bug in the test suite, so it's fine to fix it.

Okay, then I’ll ignore those for now. Thanks!

New changeset c20b701c66fc by Antoine Pitrou in branch '3.3':
Issue #18063: fix some struct specifications in the tests for sys.getsizeof().
http://hg.python.org/cpython/rev/c20b701c66fc

New changeset 5c4ca109af1c by Antoine Pitrou in branch 'default':
Issue #18063: fix some struct specifications in the tests for sys.getsizeof().
http://hg.python.org/cpython/rev/5c4ca109af1c

Should be done now :)

2.7?

2.7 doesn't have the C struct fields which were mistakingly sized in test_sys.