This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: test_urllib2_localnet fails
Type: behavior Stage: resolved
Components: Tests Versions: Python 3.3, Python 3.4, Python 2.7
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: ezio.melotti Nosy List: Mark.Shannon, ezio.melotti, orsenthil, python-dev, r.david.murray
Priority: normal Keywords: easy, patch

Created on 2013-03-27 21:46 by Mark.Shannon, last changed 2022-04-11 14:57 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
issue17564.diff ezio.melotti, 2013-03-29 20:35 review
Messages (12)
msg185379 - (view) Author: Mark Shannon (Mark.Shannon) * (Python committer) Date: 2013-03-27 21:46
The test_urllib2_localnet test fails when run with a clean build from a clean checkout.

Machine:
Ubuntu 12.04 LTS, 64 bit
Intel  i3-2370M CPU @ 2.40GHz × 4 

Test output:

$ ./python -m test -v test_urllib2_localnet
== CPython 3.4.0a0 (default:53cc3dbb1918, Mar 27 2013, 21:05:11) [GCC 4.6.3]
==   Linux-3.2.0-29-generic-x86_64-with-debian-wheezy-sid little-endian
==   /home/mark/repositories/cpython/build/test_python_4588
Testing with flags: sys.flags(debug=0, inspect=0, interactive=0, optimize=0, dont_write_bytecode=0, no_user_site=0, no_site=0, ignore_environment=0, verbose=0, bytes_warning=0, quiet=0, hash_randomization=1)
[1/1] test_urllib2_localnet
test_proxy_qop_auth_int_works_or_throws_urlerror (test.test_urllib2_localnet.ProxyAuthTests) ... ok
test_proxy_qop_auth_works (test.test_urllib2_localnet.ProxyAuthTests) ... ok
test_proxy_with_bad_password_raises_httperror (test.test_urllib2_localnet.ProxyAuthTests) ... ok
test_proxy_with_no_password_raises_httperror (test.test_urllib2_localnet.ProxyAuthTests) ... ok
test_200 (test.test_urllib2_localnet.TestUrlopen) ... ok
test_200_with_parameters (test.test_urllib2_localnet.TestUrlopen) ... ok
test_404 (test.test_urllib2_localnet.TestUrlopen) ... ok
test_bad_address (test.test_urllib2_localnet.TestUrlopen) ... FAIL
test_basic (test.test_urllib2_localnet.TestUrlopen) ... ok
test_chunked (test.test_urllib2_localnet.TestUrlopen) ... ok
test_geturl (test.test_urllib2_localnet.TestUrlopen) ... ok
test_https (test.test_urllib2_localnet.TestUrlopen) ... stopping HTTPS server
joining HTTPS thread
ok
test_https_sni (test.test_urllib2_localnet.TestUrlopen) ... stopping HTTPS server
joining HTTPS thread
ok
test_https_with_cadefault (test.test_urllib2_localnet.TestUrlopen) ... stopping HTTPS server
Got an error:
[SSL: TLSV1_ALERT_UNKNOWN_CA] tlsv1 alert unknown ca (_ssl.c:555)
joining HTTPS thread
ok
test_https_with_cafile (test.test_urllib2_localnet.TestUrlopen) ... Got an error:
[SSL: TLSV1_ALERT_UNKNOWN_CA] tlsv1 alert unknown ca (_ssl.c:555)
stopping HTTPS server
joining HTTPS thread
stopping HTTPS server
joining HTTPS thread
ok
test_info (test.test_urllib2_localnet.TestUrlopen) ... ok
test_iteration (test.test_urllib2_localnet.TestUrlopen) ... ok
test_line_iteration (test.test_urllib2_localnet.TestUrlopen) ... ok
test_redirection (test.test_urllib2_localnet.TestUrlopen) ... ok
test_sending_headers (test.test_urllib2_localnet.TestUrlopen) ... ok

======================================================================
FAIL: test_bad_address (test.test_urllib2_localnet.TestUrlopen)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/mark/repositories/cpython/Lib/test/test_urllib2_localnet.py", line 568, in test_bad_address
    "http://sadflkjsasf.i.nvali.d./")
AssertionError: OSError not raised by urlopen

----------------------------------------------------------------------
Ran 20 tests in 1.080s

FAILED (failures=1)
Warning -- threading._dangling was modified by test_urllib2_localnet
test test_urllib2_localnet failed
1 test failed:
    test_urllib2_localnet
msg185380 - (view) Author: Senthil Kumaran (orsenthil) * (Python committer) Date: 2013-03-27 21:47
Are you behind some kind of a proxy? This is seen when you are running the tests and your interent connection is via proxy (and that is handling this invalid URL test)
msg185381 - (view) Author: Ezio Melotti (ezio.melotti) * (Python committer) Date: 2013-03-27 21:52
There's a comment in the test that says it might be because of the ISP.
What happens if you try to open that address in a browser or using something like wget?
msg185382 - (view) Author: R. David Murray (r.david.murray) * (Python committer) Date: 2013-03-27 21:56
Indeed, this is almost always a (common) ISP DNS server misconfiguration.  Well, they would claim they are "helping their users", but we know better.

Not much we can do about it, except perhaps add an explanatory note to the test failure message (if assertRaises allows that...I think I requested that feature but I don't know if it has been added).
msg185383 - (view) Author: Mark Shannon (Mark.Shannon) * (Python committer) Date: 2013-03-27 21:58
Bah, stupid BT :(
I opened the URL in my browser and got a "helpful" message telling me "Sorry, the website sadflkjsasf.i.nvali.d. cannot be found"

Perhaps we should just remove this test?
I suspect this is only going to become more common.
msg185385 - (view) Author: R. David Murray (r.david.murray) * (Python committer) Date: 2013-03-27 22:08
I think we should instead have it email the ISP that their DNS is broken :)

Seriously, though, complain to your ISP.  My ISP at least provides name servers that don't have this "feature" if you prefer to use them, and they are the default for business accounts.  So they are being stupid, but less stupid than the original offender.

If you run a local DNS forwarding server, you can configure it to ignore the wildcard records from your upstream.  IMO everyone should run a local DNS caching/forwarding server for both this reason and for performance :)

If that test is run by default, we could change it to only run with -uall.  Then normal users wouldn't see it.

Now, all that said, I won't be crushed if the test gets deleted, but I will be very very sad about what that event says about modern ISPs.
msg185403 - (view) Author: Senthil Kumaran (orsenthil) * (Python committer) Date: 2013-03-28 06:24
RDM's comment:

If that test is run by default, we could change it to only run with -uall.  Then normal users wouldn't see it.

This is a good idea, only to reduce the occurrence of this test_run. Logically, this may not help at all.  I am kind of undecided on this. Shall we take a call that the next bug report on the same issue, will lead to moving this test under network cover ? :)
msg185467 - (view) Author: Ezio Melotti (ezio.melotti) * (Python committer) Date: 2013-03-28 19:57
Moving it behind -uall/-unetwork sounds good to me.
msg185514 - (view) Author: Ezio Melotti (ezio.melotti) * (Python committer) Date: 2013-03-29 20:35
Attached a patch to skip the test unless -unetwork/-uall is provided.
msg185524 - (view) Author: Senthil Kumaran (orsenthil) * (Python committer) Date: 2013-03-29 22:38
LGTM - please make the changes in all versions of python.

( I had the same patch pending locally and was waiting for my push->merge cycle time)
msg185525 - (view) Author: Roundup Robot (python-dev) (Python triager) Date: 2013-03-29 23:32
New changeset f668d2267303 by Ezio Melotti in branch '3.3':
#17564: skip test_bad_address unless the tests are run with -unetwork/-uall.
http://hg.python.org/cpython/rev/f668d2267303

New changeset a472fece6f31 by Ezio Melotti in branch '2.7':
#17564: skip test_bad_address unless the tests are run with -unetwork/-uall.
http://hg.python.org/cpython/rev/a472fece6f31
msg185526 - (view) Author: Roundup Robot (python-dev) (Python triager) Date: 2013-03-29 23:33
New changeset ae5c4a9118b8 by Ezio Melotti in branch 'default':
#17564: merge with 3.3.
http://hg.python.org/cpython/rev/ae5c4a9118b8
History
Date User Action Args
2022-04-11 14:57:43adminsetgithub: 61764
2014-10-15 04:32:20ned.deilylinkissue22639 superseder
2013-03-29 23:34:20ezio.melottisetstatus: open -> closed
assignee: ezio.melotti
resolution: fixed
stage: patch review -> resolved
2013-03-29 23:33:58python-devsetmessages: + msg185526
2013-03-29 23:32:58python-devsetnosy: + python-dev
messages: + msg185525
2013-03-29 22:38:58orsenthilsetmessages: + msg185524
2013-03-29 20:35:27ezio.melottisetfiles: + issue17564.diff
keywords: + patch
messages: + msg185514

stage: needs patch -> patch review
2013-03-28 19:57:55ezio.melottisetstatus: pending -> open
versions: + Python 2.7, Python 3.3
messages: + msg185467

keywords: + easy
stage: needs patch
2013-03-28 06:24:10orsenthilsetstatus: open -> pending

messages: + msg185403
2013-03-27 22:08:06r.david.murraysetmessages: + msg185385
2013-03-27 21:58:55Mark.Shannonsetmessages: + msg185383
2013-03-27 21:56:08r.david.murraysetnosy: + r.david.murray
messages: + msg185382
2013-03-27 21:52:45ezio.melottisetstatus: pending -> open
nosy: + ezio.melotti
messages: + msg185381

2013-03-27 21:47:58orsenthilsetstatus: open -> pending
nosy: + orsenthil
messages: + msg185380

2013-03-27 21:46:34Mark.Shannoncreate