classification
Title: Mishandled _POSIX_C_SOURCE and _XOPEN_SOURCE in pyconfig.h
Type: compile error Stage: needs patch
Components: Library (Lib) Versions: Python 3.2, Python 3.3, Python 3.4, Python 2.7
process
Status: open Resolution:
Dependencies: Superseder:
Assigned To: Nosy List: RAW, koobs, loewis, vstinner
Priority: normal Keywords:

Created on 2013-02-04 05:39 by RAW, last changed 2015-04-17 10:40 by koobs.

Messages (5)
msg181309 - (view) Author: RAW (RAW) Date: 2013-02-04 05:39
The header file pyconfig.h mishandles the _POSIX_C_SOURCE and _XOPEN_SOURCE preprocessor macros.

For older versions of Python, the pyconfig.h header specifies:

#define _POSIX_C_SOURCE 200112L

and:

#define _XOPEN_SOURCE 600

For newer versions of Python, the pyconfig.h header specifies:

#define _POSIX_C_SOURCE 200809L

and:

#define _XOPEN_SOURCE 700

The Open Group has documentation about these symbols:

http://pubs.opengroup.org/onlinepubs/007904975/functions/xsh_chap02_02.html

In particular, the documentation states:

A POSIX-conforming application should ensure that the feature test macro _POSIX_C_SOURCE is defined before inclusion of any header.

So, having a header file attempting to set _POSIX_C_SOURCE violates this intention.

Yes, I am well aware that the Python documentation says to include Python.h before any standard headers are included.  However, this is still problematic.

In particular, it causes trouble for source code that wishes to include the Python headers and wishes to use declarations that are made visible by setting later values for _POSIX_C_SOURCE and _XOPEN_SOURCE.

I would suggest the pyconfig.h be updated to have something like this:

#if !defined(_POSIX_C_SOURCE) || _POSIX_C_SOURCE < 200112L
#ifdef _POSIX_C_SOURCE
#warning Python expects -D_POSIX_C_SOURCE=200112L or later
#undef _POSIX_C_SOURCE
#endif
#define _POSIX_C_SOURCE 200112L
#endif

and this:

#if !defined(_XOPEN_SOURCE) || _XOPEN_SOURCE < 600
#ifdef _XOPEN_SOURCE
#warning Python expects -D_XOPEN_SOURCE=600 or later
#undef _XOPEN_SOURCE
#endif
#define _XOPEN_SOURCE 600
#endif
msg183910 - (view) Author: RAW (RAW) Date: 2013-03-11 02:11
Any response?
msg185248 - (view) Author: RAW (RAW) Date: 2013-03-25 23:53
Does anyone ever respond to reported issues here?
msg226849 - (view) Author: Kubilay Kocak (koobs) (Python triager) Date: 2014-09-12 22:44
See also:

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=192365
msg241328 - (view) Author: Kubilay Kocak (koobs) (Python triager) Date: 2015-04-17 10:40
@RAW, can you attach a patch against the default branch please so we can move this forward?
History
Date User Action Args
2015-04-17 10:40:12koobssetmessages: + msg241328
2014-09-16 09:52:25pitrousetnosy: + loewis
2014-09-12 22:44:05koobssetnosy: + koobs
messages: + msg226849
2013-03-25 23:57:18ezio.melottisetstage: needs patch
versions: - Python 2.6, Python 3.1, Python 3.5
2013-03-25 23:54:22vstinnersetnosy: + vstinner
2013-03-25 23:53:05RAWsetmessages: + msg185248
2013-03-25 23:51:31RAWsetstatus: languishing -> open
2013-03-11 02:11:18RAWsetstatus: open -> languishing

messages: + msg183910
2013-02-04 05:39:07RAWcreate