➜
This issue tracker has been migrated to GitHub,
and is currently read-only.
For more information,
see the GitHub FAQs in the Python's Developer Guide.
Created on 2013-01-27 22:48 by inc0, last changed 2022-04-11 14:57 by admin.
| Files | ||||
|---|---|---|---|---|
| File name | Uploaded | Description | Edit | |
| ftpcp_test.patch | inc0, 2013-01-27 22:48 | patch with test to this function | review | |
| ftpcp_test.patch | inc0, 2013-01-29 19:30 | review | ||
| ftpcp_test.patch | inc0, 2013-01-29 19:34 | review | ||
| Messages (8) | |||
|---|---|---|---|
| msg180802 - (view) | Author: Michał Jastrzębski (inc0) * | Date: 2013-01-27 22:48 | |
Test for ftplib.ftpcp. |
|||
| msg180804 - (view) | Author: Giampaolo Rodola' (giampaolo.rodola) *  |
Date: 2013-01-27 22:52 | |
ftplib.ftpcp? What is that? I do not understand what you're trying to test. ftplib test suite is already pretty extended. |
|||
| msg180836 - (view) | Author: Michał Jastrzębski (inc0) * | Date: 2013-01-28 07:45 | |
Hello, Well, I ran coverage.py over this module and it turns out that this method, ftpcp has neighter tests nor docs. Most of ftplib is tested, but this one function was not. |
|||
| msg180934 - (view) | Author: Łukasz Langa (lukasz.langa) * |
Date: 2013-01-29 19:17 | |
Thanks for your patch. A couple of remarks: - try to adhere to PEP 8 in your patches (most notably here: 80 characters per line, please). The rest of test_ftplib.py is also somewhat guilty in that regard but that shouldn't discourage you to do the right thing. - you'll notice the rest of test_ftplib.py avoids vertical whitespace within methods. This is by design. - maintain alphabetic order in Misc/ACKS |
|||
| msg180938 - (view) | Author: Michał Jastrzębski (inc0) * | Date: 2013-01-29 19:30 | |
Hello, Thanks for tips. How about now? |
|||
| msg180941 - (view) | Author: Michał Jastrzębski (inc0) * | Date: 2013-01-29 19:34 | |
My mistake, this one is better. |
|||
| msg222309 - (view) | Author: Mark Lawrence (BreamoreBoy) * | Date: 2014-07-04 19:13 | |
LGTM so can we have a commit review please. |
|||
| msg256471 - (view) | Author: Berker Peksag (berker.peksag) * |
Date: 2015-12-15 18:02 | |
ftpcp is undocumented and not part of the public API. It was added(changeset https://hg.python.org/cpython/rev/63cdfbb4a2bb#l1.433) in 1996 and it looks like its code was only touched for whitespace and PEP 8 fixes. I think we need to decide whether we want this to be documented or not. I'm not familiar with the FTP spec, but some people might find it useful: http://ftputil.sschwarzer.net/trac/ticket/15#comment:5 |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:57:41 | admin | set | github: 61257 |
| 2019-02-24 22:11:31 | BreamoreBoy | set | nosy:
- BreamoreBoy |
| 2015-12-15 18:02:20 | berker.peksag | set | nosy:
+ berker.peksag messages: + msg256471 |
| 2014-07-04 19:13:38 | BreamoreBoy | set | nosy:
+ BreamoreBoy messages: + msg222309 |
| 2013-01-29 19:34:21 | inc0 | set | files:
+ ftpcp_test.patch messages: + msg180941 |
| 2013-01-29 19:30:43 | inc0 | set | files:
+ ftpcp_test.patch messages: + msg180938 |
| 2013-01-29 19:17:24 | lukasz.langa | set | nosy:
+ lukasz.langa messages: + msg180934 |
| 2013-01-28 07:45:06 | inc0 | set | messages: + msg180836 |
| 2013-01-27 22:52:52 | giampaolo.rodola | set | messages: + msg180804 |
| 2013-01-27 22:49:04 | ezio.melotti | set | nosy:
+ giampaolo.rodola, ezio.melotti stage: patch review |
| 2013-01-27 22:48:28 | inc0 | create | |