This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Title: ZipFile.printdir fix (2.5)
Type: Stage:
Components: Library (Lib) Versions: Python 2.5
Status: closed Resolution: duplicate
Dependencies: Superseder:
Assigned To: Nosy List: alanmcintyre, nnorwitz, rhettinger
Priority: normal Keywords: patch

Created on 2007-04-12 03:22 by alanmcintyre, last changed 2022-04-11 14:56 by admin. This issue is now closed.

File name Uploaded Description Edit
zipfile-printdir-2.5-1.diff alanmcintyre, 2007-04-12 03:22 diff against rev 54769
Messages (4)
msg52414 - (view) Author: Alan McIntyre (alanmcintyre) * (Python committer) Date: 2007-04-12 03:22
This patch for 2.5 is in reference to bug [ 1698398 ] - "wrong % of params for format string in ZipFile.printdir()."  It makes the following changes:

- Modify ZipFile.printdir() to treat the ZipInfo.date_time object in a way that is similar to other code in

- Modified ZipFile.writestr() to pass a 6-item tuple to the ZipInfo constructor (consistent with other treatment of ZipInfo construction in the zipfile module) instead of the full result from time.localtime().
msg52415 - (view) Author: Alan McIntyre (alanmcintyre) * (Python committer) Date: 2007-04-12 03:27
I forgot to include that this patch passes -r
msg52416 - (view) Author: Neal Norwitz (nnorwitz) * (Python committer) Date: 2007-04-19 06:22
Closing this as a dupe of 1698917.  They are the same patch for either 2.5 or 2.6.  Either patch should apply cleanly to both the trunk and 2.5 branch (which this fix should applied to).
msg59932 - (view) Author: Raymond Hettinger (rhettinger) * (Python committer) Date: 2008-01-14 23:05
Fixed in revision 59959
Date User Action Args
2022-04-11 14:56:23adminsetgithub: 44832
2008-01-14 23:05:12rhettingersetnosy: + rhettinger
messages: + msg59932
2007-04-12 03:22:41alanmcintyrecreate