This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Title: Useless function call in
Type: enhancement Stage: commit review
Components: Library (Lib) Versions: Python 3.4
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: brett.cannon Nosy List: brett.cannon, eric.araujo, python-dev, x746e
Priority: normal Keywords: patch

Created on 2013-01-15 15:19 by x746e, last changed 2022-04-11 14:57 by admin. This issue is now closed.

File name Uploaded Description Edit
patch.diff x746e, 2013-01-15 15:19 review
Messages (4)
msg180022 - (view) Author: Kirill (x746e) Date: 2013-01-15 15:19
In Lib/ [1] _init_pathinfo call has no effect.  Looks like it's here because in the past _init_pathinfo was changing a global variable [2].  I believe that it should be changed to `known_paths = _init_pathinfo()`, in the same way as it's done in addsitedir function [3].

msg180209 - (view) Author: Brett Cannon (brett.cannon) * (Python committer) Date: 2013-01-18 18:37
I suspect Kirill is right, although the function that calls addpackage() in always passes in a value, so it won't change anything for Python itself, only third-party code. And addpackage() has been that way since 2004. But, in looking at the function itself, the function seems wrong without the change, so I say fix it in 3.4 but leave it out of 3.3.

And honestly that whole module needs to be cleaned up (again).
msg180606 - (view) Author: Roundup Robot (python-dev) (Python triager) Date: 2013-01-25 18:57
New changeset 2c0197c95ec6 by Brett Cannon in branch 'default':
Issue #16972: Have site.addpackage() consider known paths even when
msg180607 - (view) Author: Brett Cannon (brett.cannon) * (Python committer) Date: 2013-01-25 18:57
Thanks for the bug report, Kirill!
Date User Action Args
2022-04-11 14:57:40adminsetgithub: 61176
2013-01-25 18:57:59brett.cannonsetstatus: open -> closed
resolution: fixed
messages: + msg180607
2013-01-25 18:57:23python-devsetnosy: + python-dev
messages: + msg180606
2013-01-18 18:37:53brett.cannonsetassignee: brett.cannon
messages: + msg180209
stage: patch review -> commit review
2013-01-18 18:20:29ezio.melottisetnosy: + brett.cannon

stage: patch review
2013-01-16 04:37:40eric.araujosetnosy: + eric.araujo

versions: + Python 3.4
2013-01-15 15:19:18x746ecreate