➜
This issue tracker has been migrated to GitHub,
and is currently read-only.
For more information,
see the GitHub FAQs in the Python's Developer Guide.
Created on 2013-01-03 12:36 by franck, last changed 2022-04-11 14:57 by admin. This issue is now closed.
| Files | ||||
|---|---|---|---|---|
| File name | Uploaded | Description | Edit | |
| etree.patch | franck, 2013-01-03 12:36 | Full patch | review | |
| Messages (3) | |||
|---|---|---|---|
| msg178939 - (view) | Author: Franck Michea (franck) * | Date: 2013-01-03 12:36 | |
Documentation: - http://docs.python.org/3.3/library/xml.etree.elementtree.html#xml.etree.ElementTree.Element.get - http://docs.python.org/3.3/library/xml.etree.elementtree.html#xml.etree.ElementTree.Element.iter These two functions are documented with keyword arguments. Python implementation works correctly, but as of 3.3, _etreeelement module in C is hot-patching this module to enhance speed. C implementation only expects normal arguments for get and iter. This is what this patch fixes. First patch so: - I am not sure about the "key" string in kwlist array, I followed code above and it doesn't work without it, so I guess it's to for the normal arg. - I am not sure about how to test iter with this. tag argument is never used. - Included a test that shows the problem. Have a nice day, |
|||
| msg178987 - (view) | Author: Eli Bendersky (eli.bendersky) *  |
Date: 2013-01-03 20:32 | |
Thank you for the patch, Franck. I will review it when I have the time. |
|||
| msg179123 - (view) | Author: Eli Bendersky (eli.bendersky) * |
Date: 2013-01-05 14:34 | |
The patch was committed with some minor modifications to 3.3 (c1fc6b6d1cfc) and default branch (e1bee8b09828). New tests were added to the test classes (please don't add new tests to the doctests, they are deprecated). |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:57:40 | admin | set | github: 61053 |
| 2013-01-05 15:05:56 | eli.bendersky | set | status: open -> closed resolution: fixed stage: patch review -> resolved |
| 2013-01-05 14:34:46 | eli.bendersky | set | messages: + msg179123 |
| 2013-01-03 20:32:01 | eli.bendersky | set | assignee: eli.bendersky stage: patch review messages: + msg178987 versions: + Python 3.4 |
| 2013-01-03 18:47:38 | ned.deily | set | nosy:
+ eli.bendersky |
| 2013-01-03 12:36:42 | franck | create | |