Issue 15302 switched regrtest from getopt to argparse for parsing options.  However, regrtest.main() still expects and operates on getopt-style options.

This issue is to continue the regrtest refactoring and replace the use of getopt-style options with an argparse Namespace object.

This issue should probably be a meta-issue with the transition happening over several issues/commits, as there are many command-line options that will probably have varying types and actions (in the sense of argparse).  Options can be switched over incrementally in groups (e.g. by having the _parse_args() function return the parsed options in both forms: in both getopt-style format and a Namespace object).

This issue will be completed when the namespace-to-getopt "bridge code" is removed -- probably along with the corresponding argparse-to-getopt tests.

Here is a patch to start using a Namespace object.

I also noticed that the usage() function I removed in 6e2e5adc0400 is still used elsewhere in regrtest.main(), so this patch also fixes that.

The patches look good. Applied successfully and tests ran ok.

Thanks.  Andrew, could you also take a quick look at this?

May be it would be better to split the patch to two parts -- the fix of usage() bug and the enhancement.

Sure, I'd be happy to do that.  I'll prepare the patch for the other issue.

FYI, the fix for issue 16854 committed most of this patch, so the patch should be updated before reviewing.

Chris, I was reading through regrtest.py for other reasons and stumbled upon the pointer to this issue. Would you like to update your patch? I will review it.

See also issue17974.

Here is a preliminary patch which get rids of _convert_namespace_to_getopt() and directly uses a Namespace object. Unfortunately it breaks tests because test_regrtest depends on implementation details of the regrtest module and uses _convert_namespace_to_getopt(). If the proposed patch is good enough I will try to write suitable tests.

On Mon, Aug 12, 2013 at 12:41 PM, Serhiy Storchaka
<report@bugs.python.org>wrote:

>
> Serhiy Storchaka added the comment:
>
> Here is a preliminary patch which get rids of
> _convert_namespace_to_getopt() and directly uses a Namespace object.
> Unfortunately it breaks tests because test_regrtest depends on
> implementation details of the regrtest module and uses
> _convert_namespace_to_getopt(). If the proposed patch is good enough I will
> try to write suitable tests.
>

If test_regrtest is the only test broken by this, it doesn't like a major
problem.

On Mon, Aug 12, 2013 at 1:33 PM, Eli Bendersky <report@bugs.python.org>wrote:

>
> Eli Bendersky added the comment:
>
> On Mon, Aug 12, 2013 at 12:41 PM, Serhiy Storchaka
> <report@bugs.python.org>wrote:
>
> >
> > Serhiy Storchaka added the comment:
> >
> > Here is a preliminary patch which get rids of
> > _convert_namespace_to_getopt() and directly uses a Namespace object.
> > Unfortunately it breaks tests because test_regrtest depends on
> > implementation details of the regrtest module and uses
> > _convert_namespace_to_getopt(). If the proposed patch is good enough I
> will
> > try to write suitable tests.
> >
>
> If test_regrtest is the only test broken by this, it doesn't like a major
> problem.
>

Something is wrong with the part of my brain that deals with grammar today;
sorry! What I mean to say, in case it's not obvious - is that if this
change breaks no tests except the one that specifically tests regrtest
itself, I don't think there's a reason to worry. test_regrtest can (and
should) be changed not to rely on internals of the module-under-test.

Looks pretty good, Serhiy. I left some comments in Rietveld.

Thank you for the review Eli. Could you please review issue17974 while I will write tests?

As for a duplication I think about using vars():


def main(tests=None, testdir=None, verbose=0, quiet=False, ...):
    return _main(**vars())

def _main(tests, testdir, **kwargs):
    ns = argparse.Namespace(**kwargs)
    ...

Here is updated patch with tests.

Please open separated issues if you want suggest semantic changes (removing, renaming or changing behavior of some options).

New changeset 997de0edc5bd by Serhiy Storchaka in branch 'default':
Issue #16799: Switched from getopt to argparse style in regrtest's argument
http://hg.python.org/cpython/rev/997de0edc5bd