➜
This issue tracker has been migrated to GitHub,
and is currently read-only.
For more information,
see the GitHub FAQs in the Python's Developer Guide.
Created on 2012-12-13 10:22 by raninho, last changed 2022-04-11 14:57 by admin. This issue is now closed.
| Files | ||||
|---|---|---|---|---|
| File name | Uploaded | Description | Edit | |
| os_pep8.patch | raninho, 2012-12-13 10:22 | review | ||
| Messages (4) | |||
|---|---|---|---|
| msg177402 - (view) | Author: Raninho Fernandes (raninho) | Date: 2012-12-13 10:22 | |
Community, I realized that there are libraries that do not follow the standard PEP8, in order to start to contribute, I am providing the OS patch. I do not know if has community interest in the corrections (PEP8). thank you |
|||
| msg177403 - (view) | Author: Ezio Melotti (ezio.melotti) *  |
Date: 2012-12-13 11:06 | |
Thanks for your contribution, but we don't usually apply this kind of refactoring unless we are already making changes to the a specific part of the code. The reason is that even if they are trivial changes, there's an (admittedly small) chance of introducing bugs, and it makes the output of "hg annotate" more difficult to follow. Unless someone disagrees I think this can be closed as won't fix. |
|||
| msg177404 - (view) | Author: R. David Murray (r.david.murray) * |
Date: 2012-12-13 12:28 | |
That is indeed our standard policy. And yes, thank you for trying, Raninho. A good way to make an initial contribution is to look for modules that don't yet have full test coverage (there are a lot) and add tests. The devguide (http://docs.python.org/devguide) contains information about how to go about this task. |
|||
| msg177405 - (view) | Author: Raninho Fernandes (raninho) | Date: 2012-12-13 12:35 | |
I will follow the suggestion of Murray. Thanks Ezio and Murray. |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:57:39 | admin | set | github: 60877 |
| 2012-12-13 12:35:36 | raninho | set | messages: + msg177405 |
| 2012-12-13 12:28:25 | r.david.murray | set | status: pending -> closed nosy: + r.david.murray messages: + msg177404 stage: patch review -> resolved |
| 2012-12-13 11:06:46 | ezio.melotti | set | status: open -> pending type: enhancement components: + Library (Lib) versions: + Python 3.4 nosy: + ezio.melotti messages: + msg177403 resolution: wont fix stage: patch review |
| 2012-12-13 10:22:48 | raninho | create | |