➜
This issue tracker has been migrated to GitHub,
and is currently read-only.
For more information,
see the GitHub FAQs in the Python's Developer Guide.
Created on 2012-12-08 10:14 by serhiy.storchaka, last changed 2022-04-11 14:57 by admin. This issue is now closed.
| Files | ||||
|---|---|---|---|---|
| File name | Uploaded | Description | Edit | |
| sched_nonmodifiable_args.patch | serhiy.storchaka, 2012-12-08 10:18 | review | ||
| sched_nonmodifiable_args_2.patch | serhiy.storchaka, 2012-12-11 19:45 | review | ||
| Messages (5) | |||
|---|---|---|---|
| msg177151 - (view) | Author: Serhiy Storchaka (serhiy.storchaka) *  |
Date: 2012-12-08 10:14 | |
Example:
>>> import sched
>>> s=sched.scheduler()
>>> s.enter(10, 1, print)
Event(time=7452.676787873, priority=1, action=<built-in function print>, argument=[], kwargs={})
>>> next(s.queue).argument.append("spam")
>>> s.enter(5, 1, print)
Event(time=7473.326011725, priority=1, action=<built-in function print>, argument=['spam'], kwargs={})
>>> s.run()
spam
spam
Now every s.enter() call (even for other schedulers) without explicit "argument" use ['spam'] as "argument".
Usually functions should not have modifiable arguments (unless it is intentional). We should use non-modifiable value or a sentinel for default. For example an empty tuple as default for "argument" and None as default for "kwargs".
|
|||
| msg177153 - (view) | Author: Serhiy Storchaka (serhiy.storchaka) * |
Date: 2012-12-08 10:18 | |
Sorry, wrong patch. |
|||
| msg177348 - (view) | Author: Serhiy Storchaka (serhiy.storchaka) * |
Date: 2012-12-11 19:45 | |
Patch updated. Thanks Amaury for nits. |
|||
| msg178361 - (view) | Author: Giampaolo Rodola' (giampaolo.rodola) * |
Date: 2012-12-28 04:53 | |
Patch looks fine to me. |
|||
| msg178524 - (view) | Author: Roundup Robot (python-dev)  |
Date: 2012-12-29 19:17 | |
New changeset 1c9c0f92df65 by Serhiy Storchaka in branch '3.3': Issue #16641: Fix default values of sched.scheduler.enter arguments were modifiable. http://hg.python.org/cpython/rev/1c9c0f92df65 New changeset e22ebc34a8eb by Serhiy Storchaka in branch 'default': Issue #16641: Fix default values of sched.scheduler.enter arguments were modifiable. http://hg.python.org/cpython/rev/e22ebc34a8eb |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:57:39 | admin | set | github: 60845 |
| 2012-12-29 19:54:11 | serhiy.storchaka | set | status: open -> closed resolution: fixed stage: patch review -> resolved |
| 2012-12-29 19:17:06 | python-dev | set | nosy:
+ python-dev messages: + msg178524 |
| 2012-12-28 04:53:49 | giampaolo.rodola | set | messages: + msg178361 |
| 2012-12-27 21:54:30 | serhiy.storchaka | set | assignee: serhiy.storchaka |
| 2012-12-11 19:45:58 | serhiy.storchaka | set | files:
+ sched_nonmodifiable_args_2.patch messages: + msg177348 |
| 2012-12-08 10:18:59 | serhiy.storchaka | set | files:
+ sched_nonmodifiable_args.patch messages: + msg177153 |
| 2012-12-08 10:18:23 | serhiy.storchaka | set | files: - sched_nonmodifiable_args.patch |
| 2012-12-08 10:15:36 | serhiy.storchaka | set | title: sched.scheduler.enter arguments should be modifiable -> sched.scheduler.enter arguments should not be modifiable |
| 2012-12-08 10:14:21 | serhiy.storchaka | create | |