classification
Title: Declaration mismatch of quick integer allocation counters
Type: resource usage Stage: patch review
Components: Interpreter Core Versions: Python 3.2, Python 3.3
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: christian.heimes, loewis, mark.dickinson, python-dev, serhiy.storchaka
Priority: normal Keywords: patch

Created on 2012-09-17 19:52 by serhiy.storchaka, last changed 2012-09-20 20:36 by mark.dickinson. This issue is now closed.

Files
File name Uploaded Description Edit
quick_int_allocs.patch serhiy.storchaka, 2012-09-17 19:52 review
Messages (4)
msg170621 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2012-09-17 19:52
In Objects/longobject.c quick_int_allocs and quick_neg_int_allocs defined as int but in Objects/object.c they are declared and used as Py_ssize_t.

Here is a patch that fixes this mismatch.

See also issue4850.
msg170622 - (view) Author: Christian Heimes (christian.heimes) * (Python committer) Date: 2012-09-17 20:00
The patch looks good. IMO it can safely be applied as it fixes a rarely used debug feature.
msg170843 - (view) Author: Roundup Robot (python-dev) (Python triager) Date: 2012-09-20 20:31
New changeset 5ed83105731d by Mark Dickinson in branch '3.2':
Issue 15959: Fix type mismatch for quick{_neg}_int_allocs.  Thanks Serhiy Storchaka.
http://hg.python.org/cpython/rev/5ed83105731d

New changeset 3504cbb3e1d8 by Mark Dickinson in branch 'default':
Issue 15959: Merge from 3.2.
http://hg.python.org/cpython/rev/3504cbb3e1d8
msg170845 - (view) Author: Mark Dickinson (mark.dickinson) * (Python committer) Date: 2012-09-20 20:36
Fixed;  thanks for the patch!

(It seems this was fixed in Python 2 some time ago:  see issue #4850.)
History
Date User Action Args
2012-09-20 20:36:04mark.dickinsonsetstatus: open -> closed

nosy: + mark.dickinson
messages: + msg170845

resolution: fixed
2012-09-20 20:31:09python-devsetnosy: + python-dev
messages: + msg170843
2012-09-17 20:00:17christian.heimessetnosy: + christian.heimes

messages: + msg170622
stage: patch review
2012-09-17 19:52:36serhiy.storchakacreate