➜
This issue tracker has been migrated to GitHub,
and is currently read-only.
For more information,
see the GitHub FAQs in the Python's Developer Guide.
Created on 2012-09-09 21:56 by christian.heimes, last changed 2022-04-11 14:57 by admin. This issue is now closed.
| Messages (4) | |||
|---|---|---|---|
| msg170138 - (view) | Author: Christian Heimes (christian.heimes) *  |
Date: 2012-09-09 21:56 | |
The function _PyImport_GetDynLoadFunc() in Python/dynload_shlib.c doesn't check the return value of fstat() CID 486250: Other violation (CHECKED_RETURN)At (3): Calling function "fstat(fileno(fp), &statb)" without checking return value. This library function may fail and return an error code. At (4): No check of the return value of "fstat(fileno(fp), &statb)". 93 fstat(fileno(fp), &statb); Suggested fix: if (fstat(fileno(fp), &statb) == -1) { PyErr_SetFromErrnoWithFilename(PyExc_IOError, pathname); return NULL; } } |
|||
| msg193745 - (view) | Author: Christian Heimes (christian.heimes) * |
Date: 2013-07-26 20:47 | |
Already fixed |
|||
| msg193747 - (view) | Author: STINNER Victor (vstinner) * |
Date: 2013-07-26 20:49 | |
changeset: 84741:654268ff29b5 branch: 3.3 parent: 84736:ce771c2d0220 user: Christian Heimes <christian@cheimes.de> date: Sat Jul 20 22:17:55 2013 +0200 files: Python/dynload_shlib.c description: Check return value of fstat() in _PyImport_GetDynLoadFunc() CID 486250 |
|||
| msg193749 - (view) | Author: Christian Heimes (christian.heimes) * |
Date: 2013-07-26 20:51 | |
I wonder why I did not mention the issue # in the checkin message... Thanks :) |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:57:35 | admin | set | github: 60096 |
| 2013-07-26 20:51:00 | christian.heimes | set | messages: + msg193749 |
| 2013-07-26 20:49:09 | vstinner | set | nosy:
+ vstinner messages: + msg193747 |
| 2013-07-26 20:47:56 | christian.heimes | set | status: open -> closed resolution: out of date messages: + msg193745 stage: patch review -> resolved |
| 2012-11-13 06:02:22 | eric.snow | set | nosy:
+ eric.snow |
| 2012-09-10 02:26:19 | jcea | set | nosy:
+ jcea |
| 2012-09-09 21:56:02 | christian.heimes | create | |