classification
Title: Stack corruption in ssl.RAND_egd()
Type: crash Stage: resolved
Components: Library (Lib) Versions: Python 3.2, Python 3.3
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: jcea, pitrou, python-dev, serhiy.storchaka, vstinner
Priority: normal Keywords: patch

Created on 2012-08-27 21:17 by serhiy.storchaka, last changed 2012-09-11 00:24 by jcea. This issue is now closed.

Files
File name Uploaded Description Edit
ssl_RAND_egd-3.3.patch serhiy.storchaka, 2012-08-27 22:44 Patch for 3.3 review
ssl_RAND_egd-3.2.patch serhiy.storchaka, 2012-08-27 22:45 Patch for 3.2 review
Messages (5)
msg169221 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2012-08-27 21:17
Here is a patch that fixes stack corruption in ssl.RAND_egd().
msg169228 - (view) Author: Antoine Pitrou (pitrou) * (Python committer) Date: 2012-08-27 22:18
You should add a test (e.g. that TypeError is raised when a second argument is passed).
msg169237 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2012-08-27 22:44
Patch updated with tests.
msg170252 - (view) Author: Roundup Robot (python-dev) (Python triager) Date: 2012-09-11 00:24
New changeset 706115cb2cdb by Jesus Cea in branch '2.7':
Closes #15793: Stack corruption in ssl.RAND_egd(). Python 2.7 hasn't any issue about this, but add a test just to be sure
http://hg.python.org/cpython/rev/706115cb2cdb

New changeset 827bb0554f1f by Jesus Cea in branch '3.2':
Closes #15793: Stack corruption in ssl.RAND_egd()
http://hg.python.org/cpython/rev/827bb0554f1f

New changeset 7619a400d318 by Jesus Cea in branch 'default':
MERGE: Closes #15793: Stack corruption in ssl.RAND_egd()
http://hg.python.org/cpython/rev/7619a400d318
msg170253 - (view) Author: Jesús Cea Avión (jcea) * (Python committer) Date: 2012-09-11 00:24
Thanks for the detection and patch. I added a test to 2.7, even knowing it doesn't need it (2.7 is a dead end), for consistence.
History
Date User Action Args
2012-09-11 00:24:39jceasetmessages: + msg170253
2012-09-11 00:24:01python-devsetstatus: open -> closed

nosy: + python-dev
messages: + msg170252

resolution: fixed
stage: resolved
2012-08-27 22:52:01jceasetnosy: + jcea
2012-08-27 22:45:49serhiy.storchakasetfiles: - ssl_RAND_egd.patch
2012-08-27 22:45:14serhiy.storchakasetfiles: + ssl_RAND_egd-3.2.patch
2012-08-27 22:44:47serhiy.storchakasetfiles: + ssl_RAND_egd-3.3.patch

messages: + msg169237
2012-08-27 22:18:37pitrousetnosy: + pitrou
messages: + msg169228
2012-08-27 21:17:19serhiy.storchakacreate