This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Title: socketmodule cleanups: allow the use of keywords in socket functions
Type: enhancement Stage: resolved
Components: Library (Lib) Versions: Python 3.4
Status: closed Resolution: out of date
Dependencies: Superseder:
Assigned To: Nosy List: giampaolo.rodola, jafo, loewis, pitrou, therve
Priority: normal Keywords: patch

Created on 2007-12-04 16:02 by therve, last changed 2022-04-11 14:56 by admin. This issue is now closed.

File name Uploaded Description Edit
socket_keywords.diff therve, 2007-12-04 16:02
socket_keywords_2.diff therve, 2007-12-05 14:19
Messages (10)
msg58189 - (view) Author: Thomas Herve (therve) * Date: 2007-12-04 16:02
I attach a patch where I use PyArg_ParseTupleAndKeywords in socketmodule
where ARGSUSED was mentioned, or removed ARGSUSED if keywords already used.
msg58190 - (view) Author: Martin v. Löwis (loewis) * (Python committer) Date: 2007-12-04 16:26
What problem(s) does this solve?
msg58191 - (view) Author: Thomas Herve (therve) * Date: 2007-12-04 16:34
It's not really for solving a problem, it's an enhancement to allow the
functions to be called with keyword parameters.
msg58196 - (view) Author: Martin v. Löwis (loewis) * (Python committer) Date: 2007-12-04 17:17
And what problem is solved by the removal of ARGSUSED?

For the functions whose signatures you changed, can you please add
documentation and test changes as well (where necessary)?

Please don't remove the arguments PyObject* on METHO_NOARGS functions;
that is incorrect.
msg58200 - (view) Author: Thomas Herve (therve) * Date: 2007-12-04 18:32
Alright I'll add tests to the modified functions. I don't think I have
to change documentation because I kept the same name for the parameters,
but I'll check.

Looking at the patch more, maybe it doesn't make sense on the functions
taking only one parameter though :). I'll probably remove that.

Regarding ARGSUSED, I thought it was here to note functions using
PyArg_ParseTuple instead of PyArg_ParseTupleAndKeywords, but looking at
the svn history it seems wrong. I can put it back if there is another

For METH_NOARGS, do you have a pointer to explain that?, for example, show an example  of
METH_NOARGS with a function without arguments. Does that have other
msg58214 - (view) Author: Thomas Herve (therve) * Date: 2007-12-05 14:19
Here it is. There were several functions which didn't have any tests at
all, so I had to create some. These tests are likely to fail on some
platforms (like windows), but I didn't get any machine to test.
msg63798 - (view) Author: Sean Reifschneider (jafo) * (Python committer) Date: 2008-03-17 22:39
There's a new version, can we get it reviewed and tested under Windows?
msg110594 - (view) Author: Mark Lawrence (BreamoreBoy) * Date: 2010-07-17 18:48
Could someone please review these patches as they stand.  Will any rework of the patches be needed to get them into 3.2?
msg116798 - (view) Author: Mark Lawrence (BreamoreBoy) * Date: 2010-09-18 15:29
Could someone please review the latest patch, I'd like to see the OP's work rewarded with the patch getting into 3.2.
msg129449 - (view) Author: Antoine Pitrou (pitrou) * (Python committer) Date: 2011-02-25 22:46
The patch needs updating for latest 3.x.
Date User Action Args
2022-04-11 14:56:28adminsetgithub: 45895
2022-03-25 11:46:51iritkatrielsetstatus: open -> closed
resolution: out of date
stage: patch review -> resolved
2014-02-03 18:42:13BreamoreBoysetnosy: - BreamoreBoy
2013-01-22 12:39:59ezio.melottisetversions: + Python 3.4, - Python 3.3
2011-02-25 22:46:08pitrousetnosy: + pitrou, giampaolo.rodola
versions: + Python 3.3, - Python 3.2
messages: + msg129449

assignee: loewis ->
2010-09-18 15:29:41BreamoreBoysetmessages: + msg116798
2010-07-17 18:48:52BreamoreBoysetnosy: + BreamoreBoy

messages: + msg110594
versions: + Python 3.2, - Python 3.1, Python 2.7
2009-05-12 13:29:27ajaksu2setstage: patch review
versions: + Python 3.1, Python 2.7, - Python 2.6
2008-03-17 22:39:50jafosettitle: [patch] socketmodule cleanups: allow the use of keywords in socket functions -> socketmodule cleanups: allow the use of keywords in socket functions
nosy: + jafo
messages: + msg63798
priority: normal
assignee: loewis
keywords: + patch
2007-12-05 14:19:57thervesetfiles: + socket_keywords_2.diff
messages: + msg58214
2007-12-04 18:32:48thervesetmessages: + msg58200
2007-12-04 17:17:03loewissetmessages: + msg58196
2007-12-04 16:34:43thervesetmessages: + msg58191
2007-12-04 16:26:37loewissetnosy: + loewis
messages: + msg58190
2007-12-04 16:02:53thervecreate