This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Title: Removal of stale code in _csv.c / pyexpat.c
Type: Stage:
Components: Extension Modules Versions: Python 3.0
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: JosephArmbruster, christian.heimes
Priority: normal Keywords:

Created on 2007-11-27 23:09 by JosephArmbruster, last changed 2022-04-11 14:56 by admin. This issue is now closed.

Messages (2)
msg57895 - (view) Author: Joseph Armbruster (JosephArmbruster) Date: 2007-11-27 23:09
I found two code blocks that look as if they can be safely removed:

From _csv.c:

/* begin 2.2 compatibility macros */
#ifndef PyDoc_STRVAR
/* Define macros for inline documentation. */
#define PyDoc_VAR(name) static char name[]
#define PyDoc_STRVAR(name,str) PyDoc_VAR(name) = PyDoc_STR(str)
#define PyDoc_STR(str) str
#define PyDoc_STR(str) ""
#endif /* ifndef PyDoc_STRVAR */

From pyexpat.c:

#ifndef PyDoc_STRVAR

 * fdrake says:
 * Don't change the PyDoc_STR macro definition to (str), because
 * '''the parentheses cause compile failures
 * ("non-constant static initializer" or something like that)
 * on some platforms (Irix?)'''
#define PyDoc_STR(str)         str
#define PyDoc_VAR(name)        static char name[]
#define PyDoc_STRVAR(name,str) PyDoc_VAR(name) = PyDoc_STR(str)
msg57908 - (view) Author: Christian Heimes (christian.heimes) * (Python committer) Date: 2007-11-28 10:06
Fixed in r59214
Thanks Joseph! Can you find more?
Date User Action Args
2022-04-11 14:56:28adminsetgithub: 45849
2008-01-06 22:29:44adminsetkeywords: - py3k
versions: Python 3.0
2007-11-28 10:06:34christian.heimessetstatus: open -> closed
keywords: + py3k
resolution: fixed
messages: + msg57908
nosy: + christian.heimes
2007-11-27 23:09:58JosephArmbrustercreate