➜
This issue tracker has been migrated to GitHub,
and is currently read-only.
For more information,
see the GitHub FAQs in the Python's Developer Guide.
Created on 2012-06-06 01:20 by r.david.murray, last changed 2022-04-11 14:57 by admin.
| Files | ||||
|---|---|---|---|---|
| File name | Uploaded | Description | Edit | |
| restore_top_level_dir.patch | igorsobreira, 2012-07-19 22:56 | review | ||
| restore_top_level_dir_to_previous_value.patch | igorsobreira, 2012-07-20 18:35 | review | ||
| Pull Requests | |||
|---|---|---|---|
| URL | Status | Linked | Edit |
| PR 15242 | open | ZackerySpytz, 2019-08-13 01:10 | |
| Messages (5) | |||
|---|---|---|---|
| msg162387 - (view) | Author: R. David Murray (r.david.murray) *  |
Date: 2012-06-06 01:20 | |
During the execution of the load tests protocol, the loader instance will set its _top_level_dir attribute, and this will persist if the loader is passed on to another load_tests method. If that method does not specify a top_level_dir in a discovery call, the wrong top_level_dir may be used, and loading will fail. You can reproduce this by having two test *packages* with a load_tests method that calls discover in their __init__.py, and specify both package names to the unittest CLI. |
|||
| msg165887 - (view) | Author: Igor Sobreira (igorsobreira) | Date: 2012-07-19 22:56 | |
Hello. I've attached a patch to cleanup self._top_level_dir in the end of discover(). Is that the expected behavior or I'm on the wrong track? |
|||
| msg165954 - (view) | Author: Igor Sobreira (igorsobreira) | Date: 2012-07-20 17:38 | |
My previous patch is incorrect, talking to voidspace on irc self._top_leve_dir should be reverted to it's previous value "so when discover is called the original value should be stored, then discovery done, and then the original restored" I'll work on this one. He also pointed out that this bugfix should be backported to 2.7 and 3.2 |
|||
| msg165966 - (view) | Author: Igor Sobreira (igorsobreira) | Date: 2012-07-20 18:35 | |
Updated patch to restore previous value of ._top_level_dir on discover() done. And added a unit test. |
|||
| msg348649 - (view) | Author: STINNER Victor (vstinner) * |
Date: 2019-07-29 12:01 | |
This issue is not newcomer friendly, I remove the easy keyword. |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:57:31 | admin | set | github: 59215 |
| 2021-11-27 11:55:01 | iritkatriel | link | issue22811 superseder |
| 2021-11-27 11:54:46 | iritkatriel | set | versions: + Python 3.10, Python 3.11, - Python 2.7, Python 3.7, Python 3.8 |
| 2019-08-13 12:18:54 | vstinner | set | nosy:
- vstinner |
| 2019-08-13 01:12:14 | ZackerySpytz | set | nosy:
+ ZackerySpytz versions: + Python 3.7, Python 3.8, Python 3.9, - Python 3.2, Python 3.3 |
| 2019-08-13 01:10:28 | ZackerySpytz | set | stage: needs patch -> patch review pull_requests: + pull_request14963 |
| 2019-07-29 12:01:51 | vstinner | set | keywords:
- easy nosy: + vstinner messages: + msg348649 |
| 2012-07-20 18:35:19 | igorsobreira | set | files:
+ restore_top_level_dir_to_previous_value.patch messages: + msg165966 |
| 2012-07-20 17:38:30 | igorsobreira | set | messages: + msg165954 |
| 2012-07-19 22:56:56 | igorsobreira | set | files:
+ restore_top_level_dir.patch nosy: + igorsobreira messages: + msg165887 keywords: + patch |
| 2012-06-06 01:20:42 | r.david.murray | create | |