This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Title: distutils2.utils.resolve_name cleanup
Type: enhancement Stage: resolved
Components: Distutils2 Versions: Python 3.3, 3rd party
Status: closed Resolution: out of date
Dependencies: Superseder:
Assigned To: eric.araujo Nosy List: Ronny.Pfannschmidt, alexis, eric.araujo, tarek
Priority: normal Keywords: patch

Created on 2012-05-30 23:08 by Ronny.Pfannschmidt, last changed 2022-04-11 14:57 by admin. This issue is now closed.

File name Uploaded Description Edit
resolve_name.patch Ronny.Pfannschmidt, 2012-05-30 23:08
resolve_name.patch Ronny.Pfannschmidt, 2012-05-31 12:32
resolve_name.patch Ronny.Pfannschmidt, 2012-05-31 12:49
Messages (6)
msg161974 - (view) Author: Ronny Pfannschmidt (Ronny.Pfannschmidt) Date: 2012-05-30 23:08
this patch simplifies and cleans up the resolve_name function
msg161975 - (view) Author: Éric Araujo (eric.araujo) * (Python committer) Date: 2012-05-30 23:42
Thanks!  I would love to get your review on #12703 (not sure if this bug is a duplicate or an unrelated cleanup).
msg161989 - (view) Author: Ronny Pfannschmidt (Ronny.Pfannschmidt) Date: 2012-05-31 11:15
my change is a unrelated cleanup
but the ideas in the patch look good

the attribute error addition seems relevant

i'll adapt my patch to raise the original import error for toplevel import failure and accumuplate the attrbute name so it can raise the correct error
msg161995 - (view) Author: Ronny Pfannschmidt (Ronny.Pfannschmidt) Date: 2012-05-31 12:32
updated the patch with more detailed errors
msg161997 - (view) Author: Ronny Pfannschmidt (Ronny.Pfannschmidt) Date: 2012-05-31 12:49
i missused hg export, here is a corrected patch
msg164565 - (view) Author: Éric Araujo (eric.araujo) * (Python committer) Date: 2012-07-03 04:33
Closing as duplicate.  I have new tests for resolve_name (need to port them from p7g to d2 and upload a patch); if your patch makes them pass or if it can be merged with another patch that fixes the function, it’s easier to have all on one issue; if your patch makes the code more readable without fixing it then I think another patch will go in.
Date User Action Args
2022-04-11 14:57:31adminsetgithub: 59169
2014-03-13 04:21:32eric.araujosetstatus: open -> closed
resolution: out of date
stage: patch review -> resolved
2012-07-03 04:35:21eric.araujosetfiles: + resolve_name.patch
2012-07-03 04:33:59eric.araujosetfiles: - resolve_name.patch
2012-07-03 04:33:14eric.araujosetmessages: + msg164565
2012-05-31 12:49:54Ronny.Pfannschmidtsetfiles: + resolve_name.patch

messages: + msg161997
2012-05-31 12:32:33Ronny.Pfannschmidtsetfiles: + resolve_name.patch

messages: + msg161995
2012-05-31 11:15:39Ronny.Pfannschmidtsetmessages: + msg161989
2012-05-30 23:42:40eric.araujosetstage: patch review
messages: + msg161975
versions: + 3rd party, Python 3.3
2012-05-30 23:08:33Ronny.Pfannschmidtcreate