Issue 14593: PyErr_SetFromImportErrorWithNameAndPath lacks error checking

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

This issue has been migrated to GitHub: https://github.com/python/cpython/issues/58798

classification

Title:	PyErr_SetFromImportErrorWithNameAndPath lacks error checking
Type:	resource usage	Stage:	needs patch
Components:	Interpreter Core	Versions:	Python 3.3

process

Status:	closed	Resolution:	duplicate
Dependencies:		Superseder:	Change ImportError reference handling, naming View: 14600
Assigned To:		Nosy List:	brett.cannon, brian.curtin, eric.snow, pitrou
Priority:	normal	Keywords:

Created on 2012-04-16 11:38 by pitrou, last changed 2022-04-11 14:57 by admin. This issue is now closed.

Messages (1)
msg158411 - (view)	Author: Antoine Pitrou (pitrou) *	Date: 2012-04-16 11:38
The PyErr_SetFromImportErrorWithNameAndPath implementation never checks for the various results returned by the C API functions it invokes. (also, it needs documenting, see python-dev) As for PyErr_SetExcWithArgsKwargs, there's a potential refleak when args is NULL.

msg158411 - (view)

Author: Antoine Pitrou (pitrou) * (Python committer)

Date: 2012-04-16 11:38

The PyErr_SetFromImportErrorWithNameAndPath implementation never checks for the various results returned by the C API functions it invokes.

(also, it needs documenting, see python-dev)

As for PyErr_SetExcWithArgsKwargs, there's a potential refleak when args is NULL.

History
Date	User	Action	Args
2022-04-11 14:57:29	admin	set	github: 58798
2012-04-17 10:28:54	pitrou	set	status: open -> closed superseder: Change ImportError reference handling, naming resolution: duplicate
2012-04-16 17:50:54	eric.snow	set	nosy: + eric.snow
2012-04-16 11:38:44	pitrou	create