➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: Missing HCI sockets in bluetooth code from socketmodule
Type: Stage:
Components: Extension Modules Versions: Python 2.4
process
Status: closed Resolution: accepted
Dependencies: Superseder:
Assigned To: Nosy List: drphil, loewis, nnorwitz
Priority: normal Keywords: patch

Created on 2006-02-15 19:26 by drphil, last changed 2022-04-11 14:56 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
socket_bt_hci.patch drphil, 2006-02-15 19:26 patch to add hci socket support
Messages (3)
msg49489 - (view) Author: Philippe Biondi (drphil) Date: 2006-02-15 19:26 
Bluetooth code in socketmodule does not implement BTPROTO_HCI. This small patch adds the missing code.
msg49490 - (view) Author: Neal Norwitz (nnorwitz) * (Python committer) Date: 2006-03-14 07:45 
Logged In: YES 
user_id=33168

This patch is missing a return 1; in case BTPROTO_HCI:
around line 1310.  I don't know if there are other problems
or if this code is portable.

There are no tests or doc updates.
msg49491 - (view) Author: Martin v. Löwis (loewis) * (Python committer) Date: 2007-02-14 10:10 
Thanks for the patch, I committed it as r53774. I made a few modifications, like adding the return statement and guessing what the NetBSD support could be; I was not able to test any of this.

As for documentation and test suite changes: I'm willing to waive them. The bluetooth sockets are not documented at all so far, and testing them would only be possible if you have the hardware. I guess users will tell us if this is correct or whether something is missing.
History
Date User Action Args
2022-04-11 14:56:15adminsetgithub: 42906
2006-02-15 19:26:08drphilcreate