This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: packaging: test for set_platform()
Type: Stage: resolved
Components: Distutils2 Versions: Python 3.3, 3rd party
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: eric.araujo Nosy List: alexis, eric.araujo, python-dev, tarek, tshepang
Priority: normal Keywords: patch

Created on 2012-02-09 08:24 by tshepang, last changed 2022-04-11 14:57 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
test-set-platform.patch tshepang, 2012-02-09 08:24 review
test-set-platform-2.patch tshepang, 2012-02-10 21:52 review
Messages (8)
msg152933 - (view) Author: Tshepang Lekhonkhobe (tshepang) * Date: 2012-02-09 08:24
slightly increases test coverage
msg153015 - (view) Author: Éric Araujo (eric.araujo) * (Python committer) Date: 2012-02-10 04:05
Is the effect of the set_platform call permanent?  If yes, there needs to be a line like self.addCleanup(util.set_platform, util.get_platform()) to make sure the test restores its environment.
msg153079 - (view) Author: Tshepang Lekhonkhobe (tshepang) * Date: 2012-02-10 21:52
It indeed was permanent. The new patch fixes the issue.
msg153103 - (view) Author: Éric Araujo (eric.araujo) * (Python committer) Date: 2012-02-11 05:44
:) Will commit.
msg153573 - (view) Author: Roundup Robot (python-dev) (Python triager) Date: 2012-02-17 17:14
New changeset b380d715651d by Éric Araujo in branch 'default':
Add test for packaging.util.set_platform (#13974).
http://hg.python.org/cpython/rev/b380d715651d
msg153578 - (view) Author: Éric Araujo (eric.araujo) * (Python committer) Date: 2012-02-17 17:21
Also committed to d2, will push later.  Thanks!
msg154184 - (view) Author: Éric Araujo (eric.araujo) * (Python committer) Date: 2012-02-25 05:36
BTW I’m wondering if set_platform is really useful; no code currently uses it.
msg154456 - (view) Author: Roundup Robot (python-dev) (Python triager) Date: 2012-02-27 11:29
New changeset fae9d7aa7fc9 by Éric Araujo in branch 'default':
Add test for util.set_platform (#13974).
http://hg.python.org/distutils2/rev/fae9d7aa7fc9

New changeset 7d1a7251d771 by Éric Araujo in branch 'python3':
Merge fixes for #13974, #6884 and #11841 from default
http://hg.python.org/distutils2/rev/7d1a7251d771
History
Date User Action Args
2022-04-11 14:57:26adminsetgithub: 58182
2012-02-27 11:29:45python-devsetmessages: + msg154456
2012-02-25 05:36:58eric.araujosetmessages: + msg154184
2012-02-17 17:21:04eric.araujosetstatus: open -> closed
resolution: fixed
messages: + msg153578

stage: commit review -> resolved
2012-02-17 17:14:44python-devsetnosy: + python-dev
messages: + msg153573
2012-02-11 05:44:08eric.araujosetmessages: + msg153103
stage: commit review
2012-02-10 21:52:53tshepangsetfiles: + test-set-platform-2.patch

messages: + msg153079
2012-02-10 04:05:38eric.araujosetassignee: tarek -> eric.araujo
messages: + msg153015
versions: + 3rd party
2012-02-09 08:24:35tshepangcreate