This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Title: Further .vcproj cleanups
Type: Stage:
Components: Build Versions: Python 2.5
Status: closed Resolution: accepted
Dependencies: Superseder:
Assigned To: loewis Nosy List: loewis, moese, theller
Priority: high Keywords: patch

Created on 2006-01-03 15:58 by moese, last changed 2022-04-11 14:56 by admin. This issue is now closed.

File name Uploaded Description Edit
PCbuild-Clean-2.diff moese, 2006-01-03 15:58
Messages (6)
msg49252 - (view) Author: Moese (moese) Date: 2006-01-03 15:58
The #1307806 patch failed to apply completely in
r41897, probably because it was generated for Python
2.4.2 which didn't include the AST files.

I've attached a patch which will complete the cleanup
of pythoncore.vcproj and which also cleans up

Note that there is a bug in the current
pythoncore.vcproj: The BUILD macro is defined as 60, it
should be at least 67 as it was in Python 2.4.2.

I didn't fix this since I don't know what's the correct
BUILD number for Python 2.5 (68?).
msg49253 - (view) Author: Thomas Heller (theller) * (Python committer) Date: 2006-01-03 16:02
Logged In: YES 

The build number is usually set to the correct value shortly
before a binary release.
msg49254 - (view) Author: Martin v. Löwis (loewis) * (Python committer) Date: 2006-01-14 18:19
Logged In: YES 

The build number is gone in Python 2.5, so we should just
remove all traces of it; I will do that.

For reference, see PCbuild/BUILDno.txt.
msg49255 - (view) Author: Martin v. Löwis (loewis) * (Python committer) Date: 2006-01-14 18:40
Logged In: YES 

This patch is wrong: for expat, it removes HAVE_EXPAT_H,
XML_NS, etc, which are all necessary for expat to be build

Also, can you please create the patches through "svn diff"?
Then it is clearer what revision you are diffing against.
msg49256 - (view) Author: Moese (moese) Date: 2006-01-14 20:38
Logged In: YES 

The patch is fine.

HAVE_EXPAT_H and other macros are not removed. Instead the
individual definition of those macros for each file is
removed, which is exactly the purpose of this patch. You can
see those macros defined in the "PreprocessorDefinitions"
attribute of each compiler tool entry for the three
configurations (Debug, Release, Itanium Release).

Have you tried to compile the project and failed? I didn't
tried it since it would require me to checkout/export the
whole HEAD, but I would be very surprised if it didn't work.
If that's not an appropiate procedure, feel free to drop
this patch.

It was created against HEAD at that time. The files which
are modified (_elementtree.vcproj and pythoncore.vcproj)
haven't change in the meantime. So the patch is still
against HEAD. In fact, I've downloaded the current versions
of those two files and applied the patch and everything was
as intended. So I don't see the purpose of uploading another
msg49257 - (view) Author: Martin v. Löwis (loewis) * (Python committer) Date: 2006-01-15 09:27
Logged In: YES 

Thanks for the patch, I misread it. Applied as r42055.
Date User Action Args
2022-04-11 14:56:14adminsetgithub: 42755
2006-01-03 15:58:09moesecreate