➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: threading._CRLock should not be tested if _thread.RLock isn't implemented
Type: behavior Stage: resolved
Components: Tests Versions: Python 3.2, Python 3.3
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: anacrolix, neologix, python-dev
Priority: normal Keywords: patch

Created on 2012-01-28 08:44 by anacrolix, last changed 2022-04-11 14:57 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
skip-crlock-tests-if-not-implemented.patch anacrolix, 2012-01-28 08:44
Messages (3)
msg152151 - (view) Author: Matt Joiner (anacrolix) Date: 2012-01-28 08:44 
_threading.RLock is optional, and threading._CRLock is set to None if it isn't available. If this happens, the test_threading unittests crash.

Some implementations don't provide _thread.RLock.

Patch attached.
msg152155 - (view) Author: Roundup Robot (python-dev) (Python triager) Date: 2012-01-28 10:38 
New changeset 5cf181df7bea by Charles-François Natali in branch '3.2':
Issue #13894: Skip test_threading.CRLockTests if _CRLock isn't available. Patch
http://hg.python.org/cpython/rev/5cf181df7bea

New changeset 279b6d778663 by Charles-François Natali in branch 'default':
Issue #13894: Skip test_threading.CRLockTests if _CRLock isn't available. Patch
http://hg.python.org/cpython/rev/279b6d778663
msg152157 - (view) Author: Charles-François Natali (neologix) * (Python committer) Date: 2012-01-28 10:39 
Committed, thanks!
History
Date User Action Args
2022-04-11 14:57:26adminsetgithub: 58102
2012-01-28 10:39:14neologixsetstatus: open -> closed

components: + Tests, - Library (Lib)
versions: + Python 3.2
nosy: + neologix

messages: + msg152157
resolution: fixed
stage: resolved
2012-01-28 10:38:09python-devsetnosy: + python-dev
messages: + msg152155
2012-01-28 08:44:01anacrolixcreate