classification
Title: regrtest ambiguous -S flag
Type: behavior Stage: resolved
Components: Documentation, Tests Versions: Python 3.2, Python 3.3
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: docs@python Nosy List: docs@python, etukia, ezio.melotti, michael.foord, orsenthil, python-dev
Priority: normal Keywords: patch

Created on 2012-01-07 12:14 by etukia, last changed 2012-01-14 13:09 by orsenthil. This issue is now closed.

Files
File name Uploaded Description Edit
issue13726-2.patch etukia, 2012-01-14 12:45 review
Messages (6)
msg150792 - (view) Author: Erno Tukia (etukia) Date: 2012-01-07 12:14
./python -m test --help
-S/--slow       -- print the slowest 10 tests

-S is used to continue running tests after an aborted run.  It will
maintain the order a standard run (ie, this assumes -r is not used).
This is useful after the tests have prematurely stopped for some external
reason and you want to start running from where you left off rather
than starting from the beginning.

in Lib/test/regrtest.py

opts, args = getopt.getopt(sys.argv[1:], '...S...',
            [..., 'slow', ... , 'start=', ...])

for o, a in opts:
    elif o in ('-S', '--start'):
        start = a
    elif o in ('-S', '--slow'):
        print_slow = True

At the moment -S (no args) and --slow (no args) are the same, not what the documentation says and not how the code executes (-S goes with --start). Help says nothing about --start.

--slow or --start needs a new short opt, and corrected documentation.
msg151242 - (view) Author: Roundup Robot (python-dev) (Python triager) Date: 2012-01-14 10:39
New changeset 4fc5dfad766a by Senthil Kumaran in branch '3.2':
Issue13726 - Fix the  ambiguous -S flag in regrtest. It is -o/--slow for printing the 10 slowest test.
http://hg.python.org/cpython/rev/4fc5dfad766a

New changeset 9a0efac5bbcb by Senthil Kumaran in branch '3.2':
Adding the -o option for Issue13726
http://hg.python.org/cpython/rev/9a0efac5bbcb
msg151243 - (view) Author: Senthil Kumaran (orsenthil) * (Python committer) Date: 2012-01-14 10:42
I add -o as a short form for --slow. regrtest was using getopt and this conflicting option was not caught. I see it is a bug than a feature so the change is made in 3.2 and 3.3
default: b84f61fdcb4c and 6797e7458ad0

Thanks for catching this bug, Erno Tukia.
msg151250 - (view) Author: Erno Tukia (etukia) Date: 2012-01-14 12:45
--start requires an argument but short opt -S does not.

in Lib/test/regrtest.py

opts, args = getopt.getopt(sys.argv[1:], '...S...',
            [..., 'start=', ...])

Patch included.
msg151251 - (view) Author: Roundup Robot (python-dev) (Python triager) Date: 2012-01-14 13:08
New changeset c4919642fd25 by Senthil Kumaran in branch '3.2':
Fix issue13726: -S accepts an argument just as --start.
http://hg.python.org/cpython/rev/c4919642fd25

New changeset 347f6305bd26 by Senthil Kumaran in branch 'default':
merge from 3.2 - Fix issue13726: -S accepts an argument just as --start.
http://hg.python.org/cpython/rev/347f6305bd26
msg151252 - (view) Author: Senthil Kumaran (orsenthil) * (Python committer) Date: 2012-01-14 13:09
Fixed now. Thanks!
History
Date User Action Args
2012-01-14 13:09:11orsenthilsetstatus: open -> closed
resolution: fixed
messages: + msg151252
2012-01-14 13:08:28python-devsetmessages: + msg151251
2012-01-14 12:53:11etukiasetstatus: closed -> open
resolution: fixed -> (no value)
2012-01-14 12:45:44etukiasetfiles: + issue13726-2.patch
keywords: + patch
messages: + msg151250
2012-01-14 10:42:20orsenthilsetstatus: open -> closed

nosy: + orsenthil
messages: + msg151243

resolution: fixed
stage: needs patch -> resolved
2012-01-14 10:39:37python-devsetnosy: + python-dev
messages: + msg151242
2012-01-14 04:35:00terry.reedysetnosy: + ezio.melotti, michael.foord

stage: needs patch
2012-01-07 12:14:48etukiacreate