classification
Title: test_clear_dict_in_ref_cycle in test_module only works by coincidence
Type: behavior Stage: resolved
Components: Tests Versions: Python 3.2, Python 3.3
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: Mark.Shannon, benjamin.peterson, python-dev
Priority: normal Keywords: patch

Created on 2011-12-15 20:46 by Mark.Shannon, last changed 2011-12-15 20:57 by python-dev. This issue is now closed.

Files
File name Uploaded Description Edit
test_module.patch Mark.Shannon, 2011-12-15 20:46 review
Messages (2)
msg149574 - (view) Author: Mark Shannon (Mark.Shannon) * (Python committer) Date: 2011-12-15 20:46
test_clear_dict_in_ref_cycle in test_module only works by coincidence,
if the name of the variable on line 77 is changed from 'a' to 'x', then the test fails.
This is a result of the arbitrary ordering of removals of values from a modules globals() during GC. 
Patch which passes in list, rather than using a global is attached.
msg149576 - (view) Author: Roundup Robot (python-dev) (Python triager) Date: 2011-12-15 20:57
New changeset c9ae0eb66959 by Benjamin Peterson in branch 'default':
fix this test to actually test something (closes #13606)
http://hg.python.org/cpython/rev/c9ae0eb66959
History
Date User Action Args
2011-12-15 20:57:52python-devsetstatus: open -> closed

nosy: + python-dev
messages: + msg149576

resolution: fixed
stage: patch review -> resolved
2011-12-15 20:48:27pitrousetnosy: + benjamin.peterson
stage: patch review

versions: + Python 3.2, Python 3.3
2011-12-15 20:46:32Mark.Shannoncreate