classification
Title: Make use of with statement in ftplib
Type: Stage:
Components: Library (Lib) Versions: Python 3.3
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: giampaolo.rodola Nosy List: giampaolo.rodola, pitrou, python-dev
Priority: normal Keywords: easy

Created on 2011-12-09 05:21 by giampaolo.rodola, last changed 2011-12-10 20:26 by giampaolo.rodola. This issue is now closed.

Files
File name Uploaded Description Edit
ftplib.patch giampaolo.rodola, 2011-12-09 05:21 review
Messages (4)
msg149074 - (view) Author: Giampaolo Rodola' (giampaolo.rodola) * (Python committer) Date: 2011-12-09 05:21
Patch in attachment.
msg149083 - (view) Author: Antoine Pitrou (pitrou) * (Python committer) Date: 2011-12-09 10:05
The first hunk of the patch doesn't look right: ntransfercmd() is supposed to return the connection but the "with" statement closes it.
msg149185 - (view) Author: Roundup Robot (python-dev) (Python triager) Date: 2011-12-10 20:25
New changeset 6cd736239b8a by Giampaolo Rodola' in branch 'default':
fix #13563: make use of with statement in ftplib.py where needed
http://hg.python.org/cpython/rev/6cd736239b8a
msg149186 - (view) Author: Giampaolo Rodola' (giampaolo.rodola) * (Python committer) Date: 2011-12-10 20:26
That's why I nosyed you. Thanks. ;)
History
Date User Action Args
2011-12-10 20:26:13giampaolo.rodolasetstatus: open -> closed
messages: + msg149186

assignee: giampaolo.rodola
components: + Library (Lib)
keywords: + easy, - patch
resolution: fixed
2011-12-10 20:25:10python-devsetnosy: + python-dev
messages: + msg149185
2011-12-09 10:05:23pitrousetmessages: + msg149083
2011-12-09 05:21:50giampaolo.rodolacreate