This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Title: On uninstallation, distutils bdist_wininst fails to run post install script
Type: behavior Stage: resolved
Components: Distutils, Windows Versions: Python 3.1, Python 3.2, Python 2.7, Python 2.6
Status: closed Resolution: duplicate
Dependencies: Superseder: bdist_wininst-created installer does not run the postinstallation script when uninstalling
View: 13276
Assigned To: tarek Nosy List: brian.curtin, eric.araujo, jasonjroberts, mhammond, tarek
Priority: normal Keywords:

Created on 2011-11-30 16:40 by jasonjroberts, last changed 2022-04-11 14:57 by admin. This issue is now closed.

Messages (2)
msg148672 - (view) Author: Jason Roberts (jasonjroberts) Date: 2011-11-30 16:40
Historically (i.e. Python 2.6.1 and earlier) bdist_wininst would run the post install script at both installation and uninstallation. The script would be invoked with a -install argument on installation and a -remove argument on uninstallation. This stopped working in Python 2.6.2 and has not worked since.

This regression appears to have been introduced in r69094. That checkin rewrote Run_RemoveScript and associated functions in PC/bdist_wininst/install.c. The rewrite changed how the Python DLL was loaded during the remove scenario.

Previously Run_RemoveScript itself called Win32 LoadLibrary on the DLL name parsed from the wininst log file. Now Run_RemoveScript calls run_installscript instead, which ultimately calls LoadPythonDll, which calls LoadLibrary on the pythondll global variable. But nothing initializes that variable during the remove scenario and LoadLibrary fails. Ultimately run_installscript silently fails and the removal proceeds to uninstall files and registry keys, with no notification to the user that the post install script was not run.

A possible solution is to initialize pythondll in Run_RemoveScript to the DLL name parsed from the wininst log file, e.g. by inserting the following code prior to the call to run_installscript:

        strncpy(pythondll, dllname, scriptname - 1 - dllname);
        pythondll[scriptname - 1 - dllname] = '\0';

I tested this and it seemed to work fine.

I believe this problem affects all Python releases following and including 2.6.2. The version history seems to show that r69094 was propagated to all of those releases. Presumably nobody found it because post install scripts on removal are not widely used. They are, however, critical for my application (at least if I want it to clean up properly on removal) so I would appreciate this being fixed. As it stands, I have to build a private patched copy of wininst-9.0.exe to work around this problem.
msg148673 - (view) Author: Éric Araujo (eric.araujo) * (Python committer) Date: 2011-11-30 16:48
Thanks for the diagnosis.  Please contribute to the existing bug report.
Date User Action Args
2022-04-11 14:57:24adminsetgithub: 57718
2011-11-30 16:48:08eric.araujosetstatus: open -> closed
resolution: duplicate
messages: + msg148673

superseder: bdist_wininst-created installer does not run the postinstallation script when uninstalling
stage: needs patch -> resolved
2011-11-30 16:42:52brian.curtinsetnosy: + brian.curtin

components: + Windows
stage: needs patch
2011-11-30 16:40:09jasonjrobertscreate