➜
This issue tracker has been migrated to GitHub,
and is currently read-only.
For more information,
see the GitHub FAQs in the Python's Developer Guide.
Created on 2011-10-11 01:17 by pitrou, last changed 2022-04-11 14:57 by admin. This issue is now closed.
| Files | ||||
|---|---|---|---|---|
| File name | Uploaded | Description | Edit | |
| stringio.patch | pitrou, 2011-10-11 01:17 | review | ||
| Messages (6) | |||
|---|---|---|---|
| msg145322 - (view) | Author: Antoine Pitrou (pitrou) *  |
Date: 2011-10-11 01:17 | |
io.StringIO is quite slower than ''.append() when used for mass concatenation (around 5x slower). This patch brings it to similar performance by deferring construction of the internal buffer until needed. The problem is that it's very easy to disable the optimization by calling a method other than write() and getvalue(). |
|||
| msg145400 - (view) | Author: Martin v. Löwis (loewis) * |
Date: 2011-10-12 15:57 | |
It would be interesting to see how often the "bad" case triggers, i.e. that a write-only stringio sees any of the other methods invoked at all. As a special case, you may consider that .truncate(0) doesn't really need to realize the buffer first. I also wonder how much StringIO will be used in praxis, as opposed to BytesIO. |
|||
| msg145404 - (view) | Author: Antoine Pitrou (pitrou) * |
Date: 2011-10-12 16:06 | |
Yes, these are things I've been wondering about. The use-case for an append-only StringIO is obviously overlapping with the use-case for using ''.join(). However, the implementation I'm proposing is better than ''.join() when writing very small strings, since there's a periodic consolidation. > As a special case, you may consider that .truncate(0) doesn't really > need to realize the buffer first. True. Also, seek(0) then read() could use the same optimization. |
|||
| msg145571 - (view) | Author: Terry J. Reedy (terry.reedy) * |
Date: 2011-10-14 23:20 | |
Like parts of the Python test suite, I use StringIO to capture print/write output for testing in an output...output/getvalue/reset(seek(0),truncate(0)) cycle. While this enhancement would not currently affect me (as I only do a few prints each cycle), I can easily imagine other cases where it would. |
|||
| msg147411 - (view) | Author: Roundup Robot (python-dev)  |
Date: 2011-11-10 20:56 | |
New changeset 8d9a869db675 by Antoine Pitrou in branch 'default': Issue #13149: Speed up append-only StringIO objects. http://hg.python.org/cpython/rev/8d9a869db675 |
|||
| msg147412 - (view) | Author: Antoine Pitrou (pitrou) * |
Date: 2011-11-10 21:52 | |
I've committed an improved version (which also optimizes seek(0); read()). |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:57:22 | admin | set | github: 57358 |
| 2011-11-10 21:52:54 | pitrou | set | status: open -> closed resolution: fixed messages: + msg147412 stage: resolved |
| 2011-11-10 20:56:53 | python-dev | set | nosy:
+ python-dev messages: + msg147411 |
| 2011-10-14 23:20:28 | terry.reedy | set | nosy:
+ terry.reedy messages: + msg145571 |
| 2011-10-12 16:06:52 | pitrou | set | messages: + msg145404 |
| 2011-10-12 15:57:41 | loewis | set | nosy:
+ loewis messages: + msg145400 |
| 2011-10-11 01:17:34 | pitrou | create | |