This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Title: uuid4 is not tested if a uuid4 system routine isn't present
Type: behavior Stage: resolved
Components: Library (Lib) Versions: Python 3.6, Python 3.5
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: BreamoreBoy, Rosuav, anacrolix, berker.peksag, python-dev, r.david.murray
Priority: normal Keywords: patch

Created on 2011-08-22 06:41 by anacrolix, last changed 2022-04-11 14:57 by admin. This issue is now closed.

File name Uploaded Description Edit
uuid4-test-no-system-routine-fallback.patch anacrolix, 2011-08-22 06:41 review
Messages (7)
msg142688 - (view) Author: Matt Joiner (anacrolix) Date: 2011-08-22 06:41
The uuid.uuid4 function is not tested if a C system routine is not present, despite that uuid4 has several fallback clauses. This patch will test at least the first fallback.
msg221479 - (view) Author: Mark Lawrence (BreamoreBoy) * Date: 2014-06-24 19:01
I believe the code in the patch has already been applied, can somebody confirm that I'm correct please.
msg252764 - (view) Author: Chris Angelico (Rosuav) * Date: 2015-10-11 05:36
3.6 doesn't have this check, so I would say that yes, this has indeed been fixed. Issue can be closed fixed.
msg252813 - (view) Author: R. David Murray (r.david.murray) * (Python committer) Date: 2015-10-11 15:17
I doesn't look that way to me.  test_uuid4 is still skipped if there is no cytpes in 3.6, and I don't see the new test methods from the patch.  I'd say this was still valid.
msg262081 - (view) Author: Berker Peksag (berker.peksag) * (Python committer) Date: 2016-03-20 15:24
Since 756d040aa8e8, uuid.uuid4() no longer depends on ctypes. I'll remove the 'requires ctypes' condition from test_uuid4.
msg262082 - (view) Author: Roundup Robot (python-dev) (Python triager) Date: 2016-03-20 15:29
New changeset d9301ebef8d8 by Berker Peksag in branch '3.5':
Issue #12813: uuid.uuid4() no longer depends on ctypes

New changeset 462be0479f11 by Berker Peksag in branch 'default':
Issue #12813: uuid.uuid4() no longer depends on ctypes
msg262083 - (view) Author: Berker Peksag (berker.peksag) * (Python committer) Date: 2016-03-20 15:29
Thanks for the patch, Matt!
Date User Action Args
2022-04-11 14:57:20adminsetgithub: 57022
2016-03-20 15:29:59berker.peksagsetstatus: open -> closed
resolution: fixed
messages: + msg262083

stage: resolved
2016-03-20 15:29:09python-devsetnosy: + python-dev
messages: + msg262082
2016-03-20 15:24:09berker.peksagsetnosy: + berker.peksag

messages: + msg262081
versions: + Python 3.5, Python 3.6, - Python 3.3
2015-10-11 15:17:21r.david.murraysetnosy: + r.david.murray
messages: + msg252813
2015-10-11 05:36:19Rosuavsetnosy: + Rosuav
messages: + msg252764
2014-06-24 19:01:16BreamoreBoysetnosy: + BreamoreBoy
messages: + msg221479
2011-08-22 06:41:41anacrolixcreate