This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Title: Remove check for negative unsigned value in socketmodule.c
Type: behavior Stage: resolved
Components: Extension Modules Versions: Python 3.3
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: neologix, python-dev, shenki
Priority: normal Keywords: easy, patch

Created on 2011-08-22 05:23 by shenki, last changed 2022-04-11 14:57 by admin. This issue is now closed.

File name Uploaded Description Edit
bad_unsigned_check.patch shenki, 2011-08-22 05:23 review
Messages (5)
msg142674 - (view) Author: Joel (shenki) Date: 2011-08-22 05:23
fixes the following warning:

cpython/Modules/socketmodule.c:1748:74: warning: comparison of unsigned expression < 0 is always false [-Wtautological-compare]
    if (cmsgh == NULL || msg->msg_control == NULL || msg->msg_controllen < 0)
msg142865 - (view) Author: Charles-François Natali (neologix) * (Python committer) Date: 2011-08-23 21:28
I'll commit this patch tomorrow.
I noticed you didn't indicate your full name: do you mind being listed in Misc/ACKS?
msg142876 - (view) Author: Joel (shenki) Date: 2011-08-24 02:16
My full name is Joel Stanley, and yep, please add me to Misc/ACKS.
msg142891 - (view) Author: Roundup Robot (python-dev) (Python triager) Date: 2011-08-24 18:06
New changeset 4736e172fa61 by Charles-François Natali in branch 'default':
Issue12810: Remove check for negative unsigned value in socketmodule.c. Patch
msg142892 - (view) Author: Charles-François Natali (neologix) * (Python committer) Date: 2011-08-24 18:07
Patch committed.
Thanks Joel!
Date User Action Args
2022-04-11 14:57:20adminsetgithub: 57019
2011-08-24 18:07:30neologixsetstatus: open -> closed
resolution: fixed
messages: + msg142892

stage: commit review -> resolved
2011-08-24 18:06:34python-devsetnosy: + python-dev
messages: + msg142891
2011-08-24 02:16:24shenkisetmessages: + msg142876
2011-08-23 21:28:14neologixsettype: behavior
components: + Extension Modules
versions: + Python 3.3
keywords: + easy
nosy: + neologix

messages: + msg142865
stage: commit review
2011-08-22 05:23:53shenkicreate